mirror/OpenSpace
1
0
Fork 0
mirror of https://github.com/OpenSpace/OpenSpace.git synced 2026-03-13 08:58:54 -05:00
Code Issues Packages Projects Releases Wiki Activity

Fix issue when providing a URL that ends in / (closes #2435)

Browse Source
This commit is contained in:
Alexander Bock
2023-01-21 15:46:44 +01:00
parent 73e9b12567
commit c41eedf38f
1 changed files with 7 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
modules/sync/syncs/urlsynchronization.cpp
View File

@@ -146,7 +146,13 @@ void UrlSynchronization::start() {
for (const std::string& url : _urls) {
if (_filename.empty() || _urls.size() > 1) {
std::string name = std::filesystem::path(url).filename().string();
std::filesystem::path fn = std::filesystem::path(url).filename();
if (fn.empty() && url.back() == '/') {
// If the user provided a path that ends in / the `filename` will
// result in an empty path with causes the downloading to fail
fn = std::filesystem::path(url).parent_path().filename();
}
std::string name = fn.string();
// We can not create filenames with question marks
name.erase(std::remove(name.begin(), name.end(), '?'), name.end());