mirror/OpenSpace
1
0
Fork 0
mirror of https://github.com/OpenSpace/OpenSpace.git synced 2026-04-26 14:08:53 -05:00
Code Issues Packages Projects Releases Wiki Activity

Address clang tidy complaints

Browse Source 
Update Ghoul repository
Update SGCT repository
This commit is contained in:
Alexander Bock
2018-11-30 15:34:09 -05:00
parent 752750bee8
commit c7a96a6b59
121 changed files with 626 additions and 670 deletions
Download Patch File Download Diff File Expand all files Collapse all files
modules/sync/syncmodule.cpp
+1 -1
View File
@@ -114,7 +114,7 @@ void SyncModule::internalInitialize(const ghoul::Dictionary& configuration) {
_torrentClient.initialize();
global::callback::deinitialize.push_back([&]() { _torrentClient.deinitialize(); });
global::callback::deinitialize.emplace_back([&]() { _torrentClient.deinitialize(); });
}
void SyncModule::internalDeinitialize() {
modules/sync/syncs/httpsynchronization.cpp
+5 -5
View File
@@ -74,12 +74,12 @@ documentation::Documentation HttpSynchronization::Documentation() {
}
HttpSynchronization::HttpSynchronization(const ghoul::Dictionary& dict,
const std::string& synchronizationRoot,
const std::vector<std::string>& synchronizationRepositories
std::string synchronizationRoot,
std::vector<std::string> synchronizationRepositories
)
: openspace::ResourceSynchronization(dict)
, _synchronizationRoot(synchronizationRoot)
, _synchronizationRepositories(synchronizationRepositories)
, _synchronizationRoot(std::move(synchronizationRoot))
, _synchronizationRepositories(std::move(synchronizationRepositories))
{
documentation::testSpecificationAndThrow(
Documentation(),
@@ -184,7 +184,7 @@ bool HttpSynchronization::hasSyncFile() {
}
bool HttpSynchronization::trySyncFromUrl(std::string listUrl) {
HttpRequest::RequestOptions opt;
HttpRequest::RequestOptions opt = {};
opt.requestTimeoutSeconds = 0;
SyncHttpMemoryDownload fileListDownload(std::move(listUrl));
modules/sync/syncs/httpsynchronization.h
+2 -3
View File
@@ -34,9 +34,8 @@ namespace openspace {
class HttpSynchronization : public ResourceSynchronization {
public:
HttpSynchronization(const ghoul::Dictionary& dict,
const std::string& synchronizationRoot,
const std::vector<std::string>& synchronizationRepositories);
HttpSynchronization(const ghoul::Dictionary& dict, std::string synchronizationRoot,
std::vector<std::string> synchronizationRepositories);
virtual ~HttpSynchronization();
modules/sync/syncs/torrentsynchronization.cpp
+2 -2
View File
@@ -61,10 +61,10 @@ documentation::Documentation TorrentSynchronization::Documentation() {
}
TorrentSynchronization::TorrentSynchronization(const ghoul::Dictionary& dict,
const std::string& synchronizationRoot,
std::string synchronizationRoot,
TorrentClient& torrentClient)
: ResourceSynchronization(dict)
, _synchronizationRoot(synchronizationRoot)
, _synchronizationRoot(std::move(synchronizationRoot))
, _torrentClient(torrentClient)
{
documentation::testSpecificationAndThrow(
modules/sync/syncs/torrentsynchronization.h
+3 -3
View File
@@ -35,8 +35,8 @@ class TorrentSynchronizationJob;
class TorrentSynchronization : public ResourceSynchronization {
public:
TorrentSynchronization(const ghoul::Dictionary& dict,
const std::string& synchronizationRoot, TorrentClient& client);
TorrentSynchronization(const ghoul::Dictionary& dict, std::string synchronizationRoot,
TorrentClient& client);
virtual ~TorrentSynchronization();
@@ -59,7 +59,7 @@ private:
std::atomic_bool _enabled = false;
TorrentClient::TorrentId _torrentId;
TorrentClient::TorrentId _torrentId = 0;
TorrentClient::TorrentProgress _progress;
std::mutex _progressMutex;
std::string _identifier;
modules/sync/syncs/urlsynchronization.cpp
+3 -3
View File
@@ -96,9 +96,9 @@ documentation::Documentation UrlSynchronization::Documentation() {
}
UrlSynchronization::UrlSynchronization(const ghoul::Dictionary& dict,
const std::string& synchronizationRoot)
std::string synchronizationRoot)
: ResourceSynchronization(dict)
, _synchronizationRoot(synchronizationRoot)
, _synchronizationRoot(std::move(synchronizationRoot))
{
documentation::testSpecificationAndThrow(
Documentation(),
@@ -225,7 +225,7 @@ void UrlSynchronization::start() {
return !_shouldCancel;
});
HttpRequest::RequestOptions opt;
HttpRequest::RequestOptions opt = {};
opt.requestTimeoutSeconds = 0;
fileDownload->start(opt);
}
modules/sync/syncs/urlsynchronization.h
+1 -2
View File
@@ -35,8 +35,7 @@ namespace openspace {
class UrlSynchronization : public ResourceSynchronization {
public:
UrlSynchronization(const ghoul::Dictionary& dict,
const std::string& synchronizationRoot);
UrlSynchronization(const ghoul::Dictionary& dict, std::string synchronizationRoot);
virtual ~UrlSynchronization();