From e749be21a51364f8bdbf330dee631f5a297b8dd4 Mon Sep 17 00:00:00 2001 From: Malin E Date: Wed, 2 Nov 2022 17:46:20 +0100 Subject: [PATCH] Move Overlay RenderBin to before postDeffredTransparent --- modules/base/rendering/renderablemodel.cpp | 2 +- src/rendering/framebufferrenderer.cpp | 14 +++++++------- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/modules/base/rendering/renderablemodel.cpp b/modules/base/rendering/renderablemodel.cpp index 142a09aa40..7470d3265e 100644 --- a/modules/base/rendering/renderablemodel.cpp +++ b/modules/base/rendering/renderablemodel.cpp @@ -792,7 +792,7 @@ void RenderableModel::render(const RenderData& data, RendererTasks&) { // Render all parts of the model into the new framebuffer without opacity const float o = opacity(); if (o >= 0.f && o < 1.f) { - setRenderBin(Renderable::RenderBin::Overlay); + setRenderBin(Renderable::RenderBin::PostDeferredTransparent); } else { setRenderBin(Renderable::RenderBin::Opaque); diff --git a/src/rendering/framebufferrenderer.cpp b/src/rendering/framebufferrenderer.cpp index 397c930047..87f971715b 100644 --- a/src/rendering/framebufferrenderer.cpp +++ b/src/rendering/framebufferrenderer.cpp @@ -1207,6 +1207,13 @@ void FramebufferRenderer::render(Scene* scene, Camera* camera, float blackoutFac glDrawBuffers(1, &ColorAttachmentArray[_pingPongIndex]); glEnablei(GL_BLEND, 0); + { + TracyGpuZone("Overlay") + ghoul::GLDebugGroup group("Overlay"); + data.renderBinMask = static_cast(Renderable::RenderBin::Overlay); + scene->render(data, tasks); + } + { TracyGpuZone("PostDeferredTransparent") ghoul::GLDebugGroup group("PostDeferredTransparent"); @@ -1216,13 +1223,6 @@ void FramebufferRenderer::render(Scene* scene, Camera* camera, float blackoutFac scene->render(data, tasks); } - { - TracyGpuZone("Overlay") - ghoul::GLDebugGroup group("Overlay"); - data.renderBinMask = static_cast(Renderable::RenderBin::Overlay); - scene->render(data, tasks); - } - glDrawBuffer(GL_COLOR_ATTACHMENT0); // Disabling depth test for filtering and hdr