Small option property cleanup (#3577)

* Notify change listeners

I can't come up with a reason for why we would not want to do this

* Remove the Display Type for OptionProperty (only used in ImGui)

* Replace extra boolean with internal anonymous addOption function

* Tiny refactor

* removed dropdown on a couple of more places

* Update optionproperty.cpp

---------

Co-authored-by: ElonOlsson <olssonelon@gmail.com>
This commit is contained in:
Emma Broman
2025-04-02 09:28:11 +02:00
committed by GitHub
parent 80955e3ec1
commit eb709b830c
34 changed files with 115 additions and 236 deletions

View File

@@ -300,8 +300,8 @@ RenderableFieldlinesSequence::RenderableFieldlinesSequence(
const ghoul::Dictionary& dictionary)
: Renderable(dictionary)
, _colorGroup({ "Color" })
, _colorMethod(ColorMethodInfo, properties::OptionProperty::DisplayType::Radio)
, _colorQuantity(ColorQuantityInfo, properties::OptionProperty::DisplayType::Dropdown)
, _colorMethod(ColorMethodInfo)
, _colorQuantity(ColorQuantityInfo)
, _colorQuantityMinMax(
ColorMinMaxInfo,
glm::vec2(-0.f, 100.f),
@@ -342,10 +342,7 @@ RenderableFieldlinesSequence::RenderableFieldlinesSequence(
glm::vec2(-5000.f),
glm::vec2(5000.f)
)
, _maskingQuantity(
MaskingQuantityInfo,
properties::OptionProperty::DisplayType::Dropdown
)
, _maskingQuantity(MaskingQuantityInfo)
, _lineWidth(LineWidthInfo, 1.f, 1.f, 20.f)
, _jumpToStartBtn(TimeJumpButtonInfo)
{