Commit Graph

1580 Commits

Author SHA1 Message Date
benpm e623e38638 applying more suggestions from code review 2025-07-17 12:33:40 -06:00
Benjamin Mastripolito c7bbca9a81 Apply suggestions from code review
Co-authored-by: Alexander Bock <alexander.bock@liu.se>
2025-07-14 20:10:54 -06:00
benpm b8bd4928c3 Merge remote-tracking branch 'origin/master' into feature/hd-ring-shadow 2025-07-11 03:23:38 -06:00
benpm f653706480 fixed the ring transparency being used incorrectly, minor visual improvements 2025-07-11 03:21:21 -06:00
benpm a7f67d10cc minor cleanup to ring shadow shader setup code 2025-07-11 01:55:52 -06:00
benpm 5416b45bd0 improving shadow visual quality by applying additional factor based on angle to light source
see issue #3656
2025-07-10 18:02:51 -06:00
benpm 8cfce2a0f1 shadow looking pretty good! code needs cleanup and stuff tho 2025-07-09 16:32:14 -06:00
benpm ca8bdf86a6 WIP: getting a more or less correct ring texture coordinate! 2025-07-09 15:01:21 -06:00
benpm 92d42925b4 wip 2025-07-08 13:27:10 -06:00
benpm 92fa66c7fe removed the isReady() call from globe ring tex bind 2025-07-04 09:19:22 -07:00
Alexander Bock 3be7628531 Disable uniform location errors for globes when they only have a single solid color (closes #3728) 2025-07-02 17:09:25 +02:00
benpm 7f563d5125 fixed shader ready check for globe rings component 2025-07-01 01:49:07 -06:00
benpm fd5c126e15 first attempt. doesn't build :P 2025-06-24 19:33:51 -06:00
Alexander Bock 2b46271f59 Fix issue with parsing the color for a GeoJSON element 2025-05-22 16:37:56 +02:00
Benjamin Mastripolito 141fda231b Merge pull request #3634 from benpm/issue/3596-saturn-ring-shadow
Issue/3596 saturn ring shadow. fixes #3596
2025-05-20 15:17:47 -06:00
Benjamin Mastripolito 300e1089a4 Update modules/globebrowsing/shaders/rings_geom_fs.glsl
Co-authored-by: Alexander Bock <mail@alexanderbock.eu>
2025-05-19 22:31:29 -06:00
Alexander Bock b39a5f3d7b Remove deprecated Lua functions (#3664) 2025-05-19 17:59:58 +02:00
Alexander Bock f16288f53f Relocated dashboard examples. Add missing documentation entries 2025-05-18 15:44:45 +02:00
Alexander Bock 26211c1815 Fix documentation issues 2025-05-18 15:23:32 +02:00
Alexander Bock bc715e1a74 Turn ResetTileProviders in RenderableGlobe into a button 2025-05-05 14:41:05 +02:00
benpm c8243d75c1 (#3596) fixed normals in rings_geom_fs.glsl 2025-05-01 11:10:16 -06:00
benpm 94dfb26ee0 (#3596) added discard if ring normal is near perpendicular with light direction 2025-04-28 15:01:07 -06:00
benpm 0aa1edcfde (#3596) added vertex normals to ring quad vertex attribs 2025-04-25 16:10:33 -06:00
Alexander Bock 6dc738e54e Move functions about globe locations from the GlobeBrowsingModule into the core (#3613)
* Make GlobeRotation and GlobeTranslation work for non-globes and move them to the base module
* Move ellipsoid and geodetic classes into the core
* Allow more things to take scene graph nodes instead of RenderableGlobes
* Move goToGeo and related Lua functions into the core
* Move more functions from the pathnavigation namespace into the navigation namespace

---------

Co-authored-by: Emma Broman <emma.broman@liu.se>
2025-04-23 16:15:17 +02:00
Alexander Bock 8a364c16e3 Fix layout issues with Dashboards (#3614)
- Correctly render multiline text passed to a DashboardItemText
  - Invert the property for the Dashboard location to no longer need a negative y-axis
  - Use the current lineheight instead of pointsize for the ScreenLog
  - Remove the unused size function from DashboardItems
2025-04-21 01:10:02 +02:00
Emma Broman eb709b830c Small option property cleanup (#3577)
* Notify change listeners

I can't come up with a reason for why we would not want to do this

* Remove the Display Type for OptionProperty (only used in ImGui)

* Replace extra boolean with internal anonymous addOption function

* Tiny refactor

* removed dropdown on a couple of more places

* Update optionproperty.cpp

---------

Co-authored-by: ElonOlsson <olssonelon@gmail.com>
2025-04-02 09:28:11 +02:00
Alexander Bock e93ad7910f Rename propertyowner and gui to geographic overlays (#2883)
Breaking change
2025-03-24 17:12:47 +01:00
Alexander Bock edd123197f Give the GeoJSON component in the RenderableGlobe a better name (closes #2883) 2025-03-19 13:31:13 +01:00
Alexander Bock 5008aa7cd7 Adding documentation and examples (#3541)
- Make the SourceType and DestinationType parameters required in the DashboardItemAngle
  - Shift the "UTC" string in the DashboardDate from the FormatString to the TimeFormat
  - Make the SourceType and DestinationType parameters for the DashboardItemDistance required
  - Add new "Deltatime" option to the DashboardItemFramerate.  Add examples for the DashboardItemFramerate
  - Fix issue where the inputstate would not update if no option was selected
  - Automatically disable simplification if a unit is requested in the asset for a DashboardItemSimulationIncrement or DashboardItemVelocity
2025-03-14 11:25:26 +01:00
Alexander Bock fc9b2ab091 Increase the compilation speed (#3545)
- Remove toStringConversion function and move json_helper include out of numericalproperty.inl
  - Optimizing some header files
  - Remove duplicate Lua functions from properties. 
  - Move List,Option,Selection,String, and TriggerProperty into misc folder
  - Move lua_helper include out of inline file
  - Add lua_helper to the precompiled header
  - Declare property functions as final. No longer have OptionProperty derive from IntProperty
  - Remove Dictionary header from properties
2025-03-14 11:22:40 +01:00
Alexander Bock 7328a94fb1 TimeFrame specification and status (#3553)
* Makes Translation/Scale/Rotation all able to have a TimeFrame, not just the SpiceRotation.  Add read-only BoolProperty to the TimeFrame that indicates whether the current time is a in the timeframe

---------

Co-authored-by: Emma Broman <emma.broman@liu.se>
2025-03-10 13:53:32 +01:00
Alexander Bock cc395ce340 Update C++ version to 23, add new warnings and the fix them 2025-03-01 15:49:38 +01:00
Alexander Bock cd8924ed22 Remove compiler warnings on Clang/GCC (#3546) 2025-02-28 23:29:38 +01:00
Alexander Bock 5152a7a6e0 General code spring cleaning (#3525) 2025-02-22 15:28:14 +01:00
Alexander Bock 8cb3ce8b94 Add the ability to limit-rate the dashboard updating (#3527)
Co-authored-by: Emma Broman <emma.broman@liu.se>
2025-02-18 16:49:47 +01:00
Alexander Bock 588c4a6f86 Fixing assets that had problems loading (#3528)
- Correctly remove interpolating render program to prevent invalid shader access
 - Fix Apollo 11 location
 - Fix Apollo 17 location
 - Replace errors with warnings for Gala and Rime instruments for Juice
 - Correctly rely on the solarsystembarycenter asset in the Voyager/Pioneer asset
 - Use correct identifier for the Jupiter barycenter
 - NASA Treks assets
 - Slidedeck
 - Fix unloading of missions
 - No longer crash when loading and unloading image sequence assets
2025-02-17 14:08:53 +01:00
Emma Broman 1fbd5e827d Utilize new docs functionality in API scripts that are defined in Lua files (#3505)
* Fix a reference to a deprecated and renamed function in navigationstate docs

* Review documentation for scripts defined in .lua files

And utilize new markdown functionality

* Update renderable box grid size specs

So that it can have a size less than 1, and throws a specification error when the size is given as negative

* Fix some issues with the gaia filtering scripts

* Try adding param documentation to the lua script documentation

It works!

* Utiliize mroe markdown features in the updated documentations

* Add function parameter info and make small updated to gaia filtering functions

* Replace a long parameter info in description with `param` description

* Update usage examples

* Add example of how to create debug axes for the current SGN
2025-02-11 08:59:33 +01:00
Alexander Bock b8e5fab5f5 Prevent crash when moving a layer to the top of a list that only has two entries (closes #3414) 2025-02-06 13:02:02 +01:00
Alexander Bock 096363fd06 Make constructors explicit 2025-02-05 23:22:32 +01:00
Alexander Bock 5134946fbf Fix addGibsLayer script 2025-01-17 13:07:04 +01:00
Alexander Bock 820e90eab4 Happy new year 2025-01-14 16:21:08 +01:00
Emma Broman fc93523914 "Fix" invalid geometries before adding them (#3452)
However, they might not actually be completely fixed and still look weird. But at least now they load
2024-10-30 16:40:28 +01:00
Alexander Bock 390d4a3e50 Fix issue with creating RenderableGlobes with layers 2024-10-22 15:24:35 +02:00
Alexander Bock 438d6e3ddd SessionRecording and KeyframeRecording redesign (#3399) 2024-10-21 15:06:40 +02:00
Alexander Bock ff345006d1 General code cleanup (#3445) 2024-10-10 09:49:02 +02:00
Alexander Bock 125114cad5 Add documentation for TileProviderByLevel (#3446)
---------

Co-authored-by: Ylva Selling <ylva.selling@gmail.com>
2024-10-10 09:48:39 +02:00
Alexander Bock c0ca1acb33 Don't crash when enableing the shadow component on a planet that doesn't have a ring system (closes #3404) 2024-09-16 18:01:10 +02:00
Alexander Bock 06a92620d1 Ignore GlobeBrowsing shader warning when setting camera position (closes #3405) 2024-09-16 17:32:48 +02:00
Alexander Bock e24cff1d19 Handle warnings and coding style adaptations 2024-09-12 16:30:09 +02:00
Emma Broman 77672f0cc4 Fix, cleanup and simplify RenderableGlobe properties (#3408)
* Restructure "general properties" into shadow mapping and regular ones

To better connect to subpropertyowners and avoid having to specify an ordered list in constructor... Hard to keep track of

* Restructure properties in constructor to more easily find errors

* Add values that could not be set from parameters (e.g. from asset or script)

* Apply suggestions from code review

Co-authored-by: Alexander Bock <alexander.bock@liu.se>

* Address review comments

---------

Co-authored-by: Alexander Bock <alexander.bock@liu.se>
2024-09-11 16:40:38 +02:00