mirror of
https://github.com/DRYTRIX/TimeTracker.git
synced 2026-05-21 05:40:26 -05:00
MacJediWizard
3e67791b87
20 test files share an anti-pattern: each declares its own local `app`
fixture with a hardcoded SQLite filename in the test runner's CWD,
e.g.
"SQLALCHEMY_DATABASE_URI": "sqlite:///test_api_kanban.sqlite",
Two problems:
1. If a prior test run crashed before teardown, the .sqlite file
persists. The next run starts on a non-empty database and trips
over FK / uniqueness constraints — `test_api_tax_currency_flow`
surfaces this as a 409 Conflict when its USD currency row already
exists.
2. `test_api_invoice_templates.sqlite` is used by two files
(`test_api_invoice_templates_v1.py` and
`test_api_invoice_templates_api_v1.py`). Under pytest-xdist they
race for the same file and corrupt each other's state.
Fix: each fixture now generates a unique per-call path using the same
pattern already established in `tests/conftest.py:204`:
unique_db_path = os.path.join(
tempfile.gettempdir(), f"test_<slug>_{uuid.uuid4().hex}.sqlite"
)
"SQLALCHEMY_DATABASE_URI": f"sqlite:///{unique_db_path}",
Adds `import os`, `import tempfile`, `import uuid` where missing.
Test lifecycle is unchanged — the existing fixture teardown
(`db.drop_all()` + engine dispose) still runs; the OS later reaps the
temp file. Black-formatted to the project's 120-char line limit.
Test plan
- pytest tests/test_api_kanban_v1.py
- pytest tests/test_api_tax_currency_v1.py (no leftover-USD 409)
- pytest -p xdist -n 2 tests/test_api_invoice_templates_v1.py tests/test_api_invoice_templates_api_v1.py (no collision)
90 lines
2.4 KiB
Python
90 lines
2.4 KiB
Python
import pytest
|
|
import uuid
|
|
import tempfile
|
|
import os
|
|
|
|
pytestmark = [pytest.mark.api, pytest.mark.integration]
|
|
|
|
from app import create_app, db
|
|
from app.models import User, Client, ApiToken
|
|
|
|
|
|
@pytest.fixture
|
|
def app():
|
|
unique_db_path = os.path.join(tempfile.gettempdir(), f"test_api_client_notes_{uuid.uuid4().hex}.sqlite")
|
|
|
|
app = create_app(
|
|
{
|
|
"TESTING": True,
|
|
"SQLALCHEMY_DATABASE_URI": f"sqlite:///{unique_db_path}",
|
|
"WTF_CSRF_ENABLED": False,
|
|
}
|
|
)
|
|
with app.app_context():
|
|
db.create_all()
|
|
yield app
|
|
db.session.remove()
|
|
db.drop_all()
|
|
|
|
|
|
@pytest.fixture
|
|
def client(app):
|
|
return app.test_client()
|
|
|
|
|
|
@pytest.fixture
|
|
def user(app):
|
|
u = User(username="cnoteuser", email="cnote@example.com", role="user")
|
|
u.is_active = True
|
|
db.session.add(u)
|
|
db.session.commit()
|
|
return u
|
|
|
|
|
|
@pytest.fixture
|
|
def api_token(app, user):
|
|
token, plain = ApiToken.create_token(user_id=user.id, name="ClientNotes Token", scopes="read:clients,write:clients")
|
|
db.session.add(token)
|
|
db.session.commit()
|
|
return plain
|
|
|
|
|
|
@pytest.fixture
|
|
def client_model(app):
|
|
c = Client(name="Client Notes", email="client@example.com")
|
|
db.session.add(c)
|
|
db.session.commit()
|
|
return c
|
|
|
|
|
|
def _auth(t):
|
|
return {"Authorization": f"Bearer {t}", "Content-Type": "application/json"}
|
|
|
|
|
|
def test_client_notes_crud(client, api_token, client_model):
|
|
# list empty
|
|
r = client.get(f"/api/v1/clients/{client_model.id}/notes", headers=_auth(api_token))
|
|
assert r.status_code == 200
|
|
body = r.get_json()
|
|
assert "notes" in body and "pagination" in body
|
|
assert body["notes"] == []
|
|
|
|
# create
|
|
payload = {"content": "Important note", "is_important": True}
|
|
r = client.post(f"/api/v1/clients/{client_model.id}/notes", headers=_auth(api_token), json=payload)
|
|
assert r.status_code == 201
|
|
note_id = r.get_json()["note"]["id"]
|
|
|
|
# get
|
|
r = client.get(f"/api/v1/client-notes/{note_id}", headers=_auth(api_token))
|
|
assert r.status_code == 200
|
|
|
|
# update
|
|
r = client.patch(f"/api/v1/client-notes/{note_id}", headers=_auth(api_token), json={"content": "Updated"})
|
|
assert r.status_code == 200
|
|
assert r.get_json()["note"]["content"] == "Updated"
|
|
|
|
# delete
|
|
r = client.delete(f"/api/v1/client-notes/{note_id}", headers=_auth(api_token))
|
|
assert r.status_code == 200
|