mirror of
https://github.com/DRYTRIX/TimeTracker.git
synced 2026-05-24 15:20:52 -05:00
MacJediWizard
6969f9444e
Companion to #603. That earlier PR added is_license_activated guards to three donate UI gates (header support button, user-menu support link, support modal donate/buy-license buttons). Six other donate gates in templates were missed: - app/templates/base.html:1187 (sidebar nav donate entry) - app/templates/base.html:1356 (large dismissible support banner) - app/templates/main/help.html:834, 841 (help-page donate prompts) - app/templates/main/about.html:43 (about-page donate header) - app/templates/main/dashboard.html:629 (dashboard donate widget) - app/templates/reports/index.html:18 (reports-page donate prompt) Each was gated only on `current_user.ui_show_donate` (per-user flag), not on the instance-wide is_license_activated. So a licensed instance where some users still had the default ui_show_donate=true would keep showing donate prompts to those users — most prominently the big amber-gradient banner in base.html that draws the eye on every page. Repro: with settings.donate_ui_hidden=true (license active), log in as a user whose ui_show_donate is still the default true, and observe the banner at the top of every page plus the help/dashboard/reports/ about prompts — none of which respect the active license. Fix: append `and not is_license_activated` to the six leaking visibility guards. Mirror of the pattern in #603. The two about.html gates at lines 189 and 196 already check donate_ui_hidden (functionally equivalent to is_license_activated) and are left untouched. 5 files, +7 / -7 (or +9 / -9 when combined with #603's base.html edits in this same branch). No backend, schema, or behavioural change beyond the template visibility guard. Note on overlap with #603: this branch's base.html includes both PR #603's changes and this PR's changes. If #603 lands first, the base.html diff in this PR shrinks to the +2/-2 unique to it. If this PR lands first, #603 is subsumed and can be closed.