mirror of
https://github.com/DRYTRIX/TimeTracker.git
synced 2026-05-06 20:40:38 -05:00
Dries Peeters
9d1ece5263
This commit implements a complete architectural transformation of the TimeTracker application, introducing modern design patterns and comprehensive feature set. ## Architecture Improvements ### Service Layer (18 Services) - TimeTrackingService: Time entry management with timer functionality - ProjectService: Project operations and lifecycle management - InvoiceService: Invoice creation, management, and status tracking - TaskService: Task management and workflow - ExpenseService: Expense tracking and categorization - ClientService: Client relationship management - PaymentService: Payment processing and invoice reconciliation - CommentService: Comment system for projects, tasks, and quotes - UserService: User management and role operations - NotificationService: Notification delivery system - ReportingService: Report generation and analytics - AnalyticsService: Event tracking and analytics - ExportService: CSV export functionality - ImportService: CSV import with validation - EmailService: Email operations and invoice delivery - PermissionService: Role-based permission management - BackupService: Database backup operations - HealthService: System health checks and monitoring ### Repository Layer (9 Repositories) - BaseRepository: Generic CRUD operations - TimeEntryRepository: Time entry data access - ProjectRepository: Project data access with filtering - InvoiceRepository: Invoice queries and status management - TaskRepository: Task data access - ExpenseRepository: Expense data access - ClientRepository: Client data access - UserRepository: User data access - PaymentRepository: Payment data access - CommentRepository: Comment data access ### Schema Layer (9 Schemas) - Marshmallow schemas for validation and serialization - Create, update, and full schemas for all entities - Input validation and data transformation ### Utility Modules (15 Utilities) - api_responses: Standardized API response helpers - validation: Input validation utilities - query_optimization: N+1 query prevention and eager loading - error_handlers: Centralized error handling - cache: Caching foundation (Redis-ready) - transactions: Transaction management decorators - event_bus: Domain event system - performance: Performance monitoring decorators - logger: Enhanced structured logging - pagination: Pagination utilities - file_upload: Secure file upload handling - search: Full-text search utilities - rate_limiting: Rate limiting helpers - config_manager: Configuration management - datetime_utils: Enhanced date/time utilities ## Database Improvements - Performance indexes migration (15+ indexes) - Query optimization utilities - N+1 query prevention patterns ## Testing Infrastructure - Comprehensive test fixtures (conftest.py) - Service layer unit tests - Repository layer unit tests - Integration test examples ## CI/CD Pipeline - GitHub Actions workflow - Automated linting (Black, Flake8, Pylint) - Security scanning (Bandit, Safety, Semgrep) - Automated testing with coverage - Docker image builds ## Documentation - Architecture migration guide - Quick start guide - API enhancements documentation - Implementation summaries - Refactored route examples ## Key Benefits - Separation of concerns: Business logic decoupled from routes - Testability: Services and repositories can be tested in isolation - Maintainability: Consistent patterns across codebase - Performance: Database indexes and query optimization - Security: Input validation and security scanning - Scalability: Event-driven architecture and health checks ## Statistics - 70+ new files created - 8,000+ lines of code - 18 services, 9 repositories, 9 schemas - 15 utility modules - 5 test files with examples This transformation establishes a solid foundation for future development and follows industry best practices for maintainable, scalable applications.
109 lines
3.4 KiB
Python
109 lines
3.4 KiB
Python
"""
|
|
Tests for PaymentService.
|
|
"""
|
|
|
|
import pytest
|
|
from decimal import Decimal
|
|
from datetime import date
|
|
from app.services import PaymentService
|
|
from app.repositories import PaymentRepository, InvoiceRepository
|
|
from app.models import Payment, Invoice
|
|
|
|
|
|
class TestPaymentService:
|
|
"""Test cases for PaymentService"""
|
|
|
|
def test_create_payment_success(self, db_session, sample_invoice, sample_user):
|
|
"""Test successful payment creation"""
|
|
service = PaymentService()
|
|
|
|
result = service.create_payment(
|
|
invoice_id=sample_invoice.id,
|
|
amount=Decimal('100.00'),
|
|
payment_date=date.today(),
|
|
currency='EUR',
|
|
method='bank_transfer',
|
|
received_by=sample_user.id
|
|
)
|
|
|
|
assert result['success'] is True
|
|
assert result['payment'] is not None
|
|
assert result['payment'].amount == Decimal('100.00')
|
|
assert result['payment'].invoice_id == sample_invoice.id
|
|
|
|
def test_create_payment_invalid_invoice(self, db_session, sample_user):
|
|
"""Test payment creation with invalid invoice"""
|
|
service = PaymentService()
|
|
|
|
result = service.create_payment(
|
|
invoice_id=99999,
|
|
amount=Decimal('100.00'),
|
|
payment_date=date.today(),
|
|
received_by=sample_user.id
|
|
)
|
|
|
|
assert result['success'] is False
|
|
assert result['error'] == 'invalid_invoice'
|
|
|
|
def test_create_payment_invalid_amount(self, db_session, sample_invoice, sample_user):
|
|
"""Test payment creation with invalid amount"""
|
|
service = PaymentService()
|
|
|
|
result = service.create_payment(
|
|
invoice_id=sample_invoice.id,
|
|
amount=Decimal('0.00'),
|
|
payment_date=date.today(),
|
|
received_by=sample_user.id
|
|
)
|
|
|
|
assert result['success'] is False
|
|
assert result['error'] == 'invalid_amount'
|
|
|
|
def test_get_invoice_payments(self, db_session, sample_invoice, sample_user):
|
|
"""Test getting payments for an invoice"""
|
|
service = PaymentService()
|
|
|
|
# Create payments
|
|
service.create_payment(
|
|
invoice_id=sample_invoice.id,
|
|
amount=Decimal('50.00'),
|
|
payment_date=date.today(),
|
|
received_by=sample_user.id
|
|
)
|
|
|
|
service.create_payment(
|
|
invoice_id=sample_invoice.id,
|
|
amount=Decimal('50.00'),
|
|
payment_date=date.today(),
|
|
received_by=sample_user.id
|
|
)
|
|
|
|
payments = service.get_invoice_payments(sample_invoice.id)
|
|
|
|
assert len(payments) == 2
|
|
assert sum(p.amount for p in payments) == Decimal('100.00')
|
|
|
|
def test_get_total_paid(self, db_session, sample_invoice, sample_user):
|
|
"""Test getting total paid for an invoice"""
|
|
service = PaymentService()
|
|
|
|
# Create payments
|
|
service.create_payment(
|
|
invoice_id=sample_invoice.id,
|
|
amount=Decimal('75.00'),
|
|
payment_date=date.today(),
|
|
received_by=sample_user.id
|
|
)
|
|
|
|
service.create_payment(
|
|
invoice_id=sample_invoice.id,
|
|
amount=Decimal('25.00'),
|
|
payment_date=date.today(),
|
|
received_by=sample_user.id
|
|
)
|
|
|
|
total = service.get_total_paid(sample_invoice.id)
|
|
|
|
assert total == Decimal('100.00')
|
|
|