mirror of
https://github.com/DRYTRIX/TimeTracker.git
synced 2026-05-24 15:20:52 -05:00
Dries Peeters
427074398c
- Refactor migrations with idempotency checks and better error handling * Add SQLAlchemy inspector checks for table/column existence * Improve error messages and handling for schema operations * Make migrations safe to run multiple times * Update 27 migration files with enhanced error handling patterns - Add missing schema columns via new migrations * Migration 095: Add ui_show_issues column to users table * Migration 096: Add portal_issues_enabled column to clients table - Enhance Settings model error handling * Improve detection of schema errors (table/column missing) * Better handling of SQLAlchemy exceptions during migrations * More comprehensive error checking for OperationalErrors - Fix database auto-switching logic in app initialization * Respect explicit DATABASE_URL setting to prevent unwanted switches * Only auto-switch to PostgreSQL when not explicitly configured - Update docker entrypoint script with migration improvements
112 lines
3.5 KiB
Python
112 lines
3.5 KiB
Python
from __future__ import with_statement
|
|
|
|
import logging
|
|
from logging.config import fileConfig
|
|
|
|
from flask import current_app
|
|
|
|
from alembic import context
|
|
|
|
# this is the Alembic Config object, which provides
|
|
# access to the values within the .ini file in use.
|
|
config = context.config
|
|
|
|
# Interpret the config file for Python logging.
|
|
# This line sets up loggers basically.
|
|
fileConfig(config.config_file_name)
|
|
logger = logging.getLogger('alembic.env')
|
|
|
|
# add your model's MetaData object here
|
|
# for 'autogenerate' support
|
|
# from myapp import mymodel
|
|
# target_metadata = mymodel.metadata
|
|
config.set_main_option(
|
|
'sqlalchemy.url',
|
|
str(current_app.extensions['migrate'].db.get_engine().url).replace(
|
|
'%', '%%'))
|
|
target_metadata = current_app.extensions['migrate'].db.metadata
|
|
|
|
# other values from the config, defined by the needs of env.py,
|
|
# can be acquired:
|
|
# my_important_option = config.get_main_option("my_important_option")
|
|
# ... etc.
|
|
|
|
|
|
def run_migrations_offline():
|
|
"""Run migrations in 'offline' mode.
|
|
|
|
This configures the context with just a URL
|
|
and not an Engine, though an Engine is acceptable
|
|
here as well. By skipping the Engine creation
|
|
we don't even need a DBAPI to be available.
|
|
|
|
Calls to context.execute() here emit the given string to the
|
|
script output.
|
|
|
|
"""
|
|
url = config.get_main_option("sqlalchemy.url")
|
|
context.configure(
|
|
url=url, target_metadata=target_metadata, literal_binds=True
|
|
)
|
|
|
|
with context.begin_transaction():
|
|
context.run_migrations()
|
|
|
|
|
|
def run_migrations_online():
|
|
"""Run migrations in 'online' mode.
|
|
|
|
In this scenario we need to create an Engine
|
|
and associate a connection with the context.
|
|
|
|
"""
|
|
|
|
# this callback is used to prevent an auto-migration from being generated
|
|
# when there are no changes to the schema
|
|
# reference: http://alembic.zzzcomputing.com/en/latest/cookbook.html
|
|
def process_revision_directives(context, revision, directives):
|
|
if getattr(config.cmd_opts, 'autogenerate', False):
|
|
script = directives[0]
|
|
if script.upgrade_ops.is_empty():
|
|
directives[:] = []
|
|
logger.info('No changes in schema detected.')
|
|
|
|
connectable = current_app.extensions['migrate'].db.get_engine()
|
|
|
|
try:
|
|
with connectable.connect() as connection:
|
|
context.configure(
|
|
connection=connection,
|
|
target_metadata=target_metadata,
|
|
process_revision_directives=process_revision_directives,
|
|
**current_app.extensions['migrate'].configure_args
|
|
)
|
|
|
|
with context.begin_transaction():
|
|
context.run_migrations()
|
|
except Exception as e:
|
|
# Log the full error with traceback for debugging
|
|
import traceback
|
|
logger.error(f"Migration failed with error: {e}")
|
|
logger.error(f"Traceback:\n{traceback.format_exc()}")
|
|
# Re-raise to ensure the migration command fails properly
|
|
raise
|
|
|
|
|
|
if context.is_offline_mode():
|
|
try:
|
|
run_migrations_offline()
|
|
except Exception as e:
|
|
import traceback
|
|
logger.error(f"Migration failed (offline mode) with error: {e}")
|
|
logger.error(f"Traceback:\n{traceback.format_exc()}")
|
|
raise
|
|
else:
|
|
try:
|
|
run_migrations_online()
|
|
except Exception as e:
|
|
import traceback
|
|
logger.error(f"Migration failed (online mode) with error: {e}")
|
|
logger.error(f"Traceback:\n{traceback.format_exc()}")
|
|
raise
|