added todo tasks

This commit is contained in:
silverqx
2022-03-06 12:32:43 +01:00
parent 9a54b520bc
commit bbd36faeba
5 changed files with 5 additions and 2 deletions
+1
View File
@@ -537,6 +537,7 @@ namespace Schema
if (causedByLostConnection(e)) {
reconnect();
// BUG rethrow e when causedByLostConnection to correctly inform user, causedByLostConnection state lost during second runQueryCallback(), because it internally tries to connect to DB and throws "Unable to connect to database" instead of "Lost connection", probably another try-catch and if catched "Unable to connect to database" then rethrow e (Lost connection)? silverqx
return runQueryCallback(queryString, bindings, callback);
}
+1 -1
View File
@@ -412,7 +412,7 @@ namespace Concerns
const auto position = m_attributesHash.at(key);
// FUTURE all the operations on this containers should be synchronized silverqx
// FUTURE all the operations on this containers should be synchronized, later, I think that this is not true because connection or model can be used only from a thread where it was created silverqx
m_attributes.removeAt(position);
m_attributesHash.erase(key);
@@ -670,6 +670,7 @@ namespace Orm::Tiny::Concerns
/* HasRelationStore */
// CUR1 clang-tidy fix modernize-use-equals-delete silverqx
template<typename Derived, AllRelationsConcept ...AllRelations>
HasRelationStore<Derived, AllRelations...>::HasRelationStore(
#ifdef TINYORM_DEBUG
+1
View File
@@ -1319,3 +1319,4 @@ TINYORM_END_COMMON_NAMESPACE
// CUR docs exceptions, which methods throw which exceptions, so user know which exception classes to define in a catch blocks silverqx
// CUR Belongs To Many firstOrNew, firstOrCreate, and updateOrCreate Methods, revisit first and second argument silverqx
// CUR add attribute to touch() method silverqx
// SEC fix LoadLibrary() before qsql plugin loads? https://www.qt.io/blog/security-advisory-qlockfile-qauthenticator-windows-platform-plugin silverqx
+1 -1
View File
@@ -16,7 +16,7 @@ bool DetectsLostConnections::causedByLostConnection(const Exceptions::SqlError &
bool DetectsLostConnections::causedByLostConnection(const QSqlError &e) const
{
// TODO verify this will be pain in the ass 😕 silverqx
// TODO verify this will be pain in the ass 😕, but but it looks like few of them for mysql and postgres are completly valid silverqx
static const QVector<QString> lostMessagesCache {
QLatin1String("server has gone away"),
QLatin1String("no connection to the server"),