mirror/UNIT3D-Community-Edition
1
0
Fork 0
mirror of https://github.com/HDInnovations/UNIT3D-Community-Edition.git synced 2026-04-23 19:50:40 -05:00
Code Issues Packages Projects Releases Wiki Activity

fix: strict type issues

Browse Source 
Don't pass null into functions that don't accept null.
This commit is contained in:
Roardom
2024-05-23 17:40:16 +00:00
parent b1873bfa27
commit 12903f64ac
27 changed files with 98 additions and 78 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/Http/Controllers/ApprovedRequestFillController.php
+5 -5
View File
@@ -47,14 +47,14 @@ class ApprovedRequestFillController extends Controller
abort_unless(($request->user()->id === $torrentRequest->user_id || $request->user()->group->is_modo) && $torrentRequest->approved_by === null, 403);
$approver = $request->user();
$filler = $torrentRequest->filler;
$filler = $torrentRequest->filler()->sole();
$torrentRequest->update([
'approved_by' => $approver->id,
'approved_when' => Carbon::now(),
]);
$filler->increment('seedbonus', $torrentRequest->bounty);
$filler->increment('seedbonus', (float) $torrentRequest->bounty);
// Achievements
if (!$torrentRequest->filled_anon) {
@@ -88,7 +88,7 @@ class ApprovedRequestFillController extends Controller
*/
public function destroy(Request $request, TorrentRequest $torrentRequest): \Illuminate\Http\RedirectResponse
{
abort_unless($request->user()->group->is_modo, 403);
abort_unless((bool) $request->user()->group->is_modo, 403);
$filler = $torrentRequest->filler;
@@ -98,9 +98,9 @@ class ApprovedRequestFillController extends Controller
]);
// TODO: Change database column to signed from unsigned to handle negative bon.
$refunded = min($torrentRequest->bounty, $filler->seedbonus);
$refunded = min($torrentRequest->bounty, (float) $filler->seedbonus);
$filler->decrement('seedbonus', $refunded);
$filler->decrement('seedbonus', (float) $refunded);
return to_route('requests.show', ['torrentRequest' => $torrentRequest])
->withSuccess(trans('request.request-reset'));