(Update) Refactor General and Staff Controllers

- Remove all facades use besides mail
- Use Dependency Injection for Illuminate\Http\Request
- use helpers for auth, cache, validator, and more to rid of facades use
- use $request->input() over $request->get()
- use $request->isMethod('POST') over $request->getMethod('POST')
- general cleanup
This commit is contained in:
HDVinnie
2018-03-15 12:32:40 -04:00
parent eabf4a68ca
commit 2da7207d2b
51 changed files with 631 additions and 892 deletions
+17 -18
View File
@@ -13,10 +13,9 @@
namespace App\Http\Controllers\Staff;
use App\Http\Controllers\Controller;
use Illuminate\Http\Request;
use App\Page;
use Illuminate\Support\Facades\Request;
use Illuminate\Support\Facades\Session;
use Illuminate\Support\Facades\Validator;
use \Toastr;
class PageController extends Controller
{
@@ -38,20 +37,20 @@ class PageController extends Controller
*
*
*/
public function add()
public function add(Request $request)
{
if (Request::getMethod() == 'POST') {
if ($request->isMethod('POST')) {
$page = new Page();
$page->name = Request::get('name');
$page->name = $request->input('name');
$page->slug = str_slug($page->name);
$page->content = Request::get('content');
$page->content = $request->input('content');
$v = Validator::make($page->toArray(), ['name' => 'required', 'slug' => 'required', 'content' => 'required']);
$v = validator($page->toArray(), ['name' => 'required', 'slug' => 'required', 'content' => 'required']);
if ($v->passes()) {
$page->save();
return redirect()->route('staff_page_index');
return redirect()->route('staff_page_index')->with(Toastr::success('Page has been created successfully', 'Yay!', ['options']));
} else {
Session::put('message', 'An error has occurred');
return redirect()->back()->with(Toastr::error('Page failed to save', 'Whoops!', ['options']));
}
}
return view('Staff.page.add');
@@ -62,20 +61,20 @@ class PageController extends Controller
*
*
*/
public function edit($slug, $id)
public function edit(Request $request, $slug, $id)
{
$page = Page::findOrFail($id);
if (Request::getMethod() == 'POST') {
$page->name = Request::get('name');
if ($request->isMethod('POST')) {
$page->name = $request->input('name');
$page->slug = str_slug($page->name);
$page->content = Request::get('content');
$page->content = $request->input('content');
$v = Validator::make($page->toArray(), ['name' => 'required', 'slug' => 'required', 'content' => 'required']);
$v = validator($page->toArray(), ['name' => 'required', 'slug' => 'required', 'content' => 'required']);
if ($v->passes()) {
$page->save();
return redirect()->route('staff_page_index')->with('message', 'Page edited successfully');
return redirect()->route('staff_page_index')->with(Toastr::success('Page has been edited successfully', 'Yay!', ['options']));
} else {
Session::put('message', 'An error has occurred');
return redirect()->back()->with(Toastr::error('Page failed to save', 'Whoops!', ['options']));
}
}
return view('Staff.page.edit', ['page' => $page]);
@@ -89,6 +88,6 @@ class PageController extends Controller
public function delete($slug, $id)
{
Page::findOrFail($id)->delete();
return redirect()->route('staff_page_index')->with('message', 'Page successfully deleted');
return redirect()->route('staff_page_index')->with(Toastr::success('Page has been deleted successfully', 'Yay!', ['options']));
}
}