refactor: better php8 usage

- Change simple property init and assign to constructor promotion
- Remove unused variable in catch()
- Change docs types to union types, where possible
This commit is contained in:
HDVinnie
2021-05-15 22:41:28 -04:00
parent 041927202c
commit 3407075214
174 changed files with 237 additions and 1365 deletions
@@ -39,9 +39,6 @@ class ChatController extends Controller
{
/**
* ChatController Constructor.
*
* @param \App\Repositories\ChatRepository $chatRepository
* @param \Illuminate\Contracts\Auth\Factory $authFactory
*/
public function __construct(private ChatRepository $chatRepository, private Factory $authFactory)
{
+2 -10
View File
@@ -40,8 +40,6 @@ class TorrentController extends BaseController
{
/**
* TorrentController Constructor.
*
* @param \App\Repositories\ChatRepository $chatRepository
*/
public function __construct(private ChatRepository $chatRepository)
{
@@ -60,13 +58,11 @@ class TorrentController extends BaseController
/**
* Store a newly created resource in storage.
*
* @param \Illuminate\Http\Request $request
*
* @throws \Illuminate\Contracts\Container\BindingResolutionException
*
* @return \Illuminate\Http\JsonResponse|\Illuminate\Http\Response
*/
public function store(Request $request)
public function store(Request $request): \Illuminate\Http\JsonResponse|\Illuminate\Http\Response
{
$user = $request->user();
$requestFile = $request->file('torrent');
@@ -84,7 +80,7 @@ class TorrentController extends BaseController
try {
$meta = Bencode::get_meta($decodedTorrent);
} catch (\Exception $exception) {
} catch (\Exception) {
return $this->sendError('Validation Error.', 'You Must Provide A Valid Torrent File For Upload!');
}
@@ -281,9 +277,7 @@ class TorrentController extends BaseController
/**
* Update the specified resource in storage.
*
* @param \Illuminate\Http\Request $request
* @param int $id
*
* @return void
*/
public function update(Request $request, $id)
@@ -306,8 +300,6 @@ class TorrentController extends BaseController
/**
* Uses Input's To Put Together A Search.
*
* @param \Illuminate\Http\Request $request
* @param \App\Models\Torrent $torrent
*
* @return TorrentsResource
*/