mirror/UNIT3D-Community-Edition
1
0
Fork 0
mirror of https://github.com/HDInnovations/UNIT3D-Community-Edition.git synced 2026-04-22 10:08:31 -05:00
Code Issues Packages Projects Releases Wiki Activity

refactor: better php8 usage

Browse Source 
- Change simple property init and assign to constructor promotion
- Remove unused variable in catch()
- Change docs types to union types, where possible
This commit is contained in:
HDVinnie
2021-05-15 22:41:28 -04:00
parent 041927202c
commit 3407075214
174 changed files with 237 additions and 1365 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/Http/Controllers/TopicController.php
+3 -22
View File
@@ -41,9 +41,6 @@ class TopicController extends Controller
{
/**
* TopicController Constructor.
*
* @param \App\Repositories\TaggedUserRepository $taggedUserRepository
* @param \App\Repositories\ChatRepository $chatRepository
*/
public function __construct(private TaggedUserRepository $taggedUserRepository, private ChatRepository $chatRepository)
{
@@ -55,10 +52,8 @@ class TopicController extends Controller
* @param \App\Models\Topic $id
* @param string $page
* @param string $post
*
* @return \Illuminate\Contracts\View\Factory|\Illuminate\View\View
*/
public function topic($id, $page = '', $post = '')
public function topic($id, $page = '', $post = ''): \Illuminate\Contracts\View\Factory|\Illuminate\View\View
{
// Find the topic
$topic = Topic::findOrFail($id);
@@ -103,12 +98,10 @@ class TopicController extends Controller
/**
* Topic Add Form.
*
* @param \Illuminate\Http\Request $request
* @param \App\Models\Forum $id
*
* @return \Illuminate\Contracts\View\Factory|\Illuminate\View\View
*/
public function addForm(Request $request, $id)
public function addForm(Request $request, $id): \Illuminate\Contracts\View\Factory|\Illuminate\View\View
{
$forum = Forum::findOrFail($id);
$category = $forum->getCategory();
@@ -129,9 +122,7 @@ class TopicController extends Controller
/**
* Create A New Topic In The Forum.
*
* @param \Illuminate\Http\Request $request
* @param \App\Models\Forum $id
*
* @return \Illuminate\Http\RedirectResponse
*/
public function newTopic(Request $request, $id)
@@ -237,10 +228,8 @@ class TopicController extends Controller
* Topic Edit Form.
*
* @param \App\Models\Topic $id
*
* @return \Illuminate\Contracts\View\Factory|\Illuminate\View\View
*/
public function editForm($id)
public function editForm($id): \Illuminate\Contracts\View\Factory|\Illuminate\View\View
{
$topic = Topic::findOrFail($id);
$categories = Forum::where('parent_id', '!=', 0)->get();
@@ -251,9 +240,7 @@ class TopicController extends Controller
/**
* Edit Topic In The Forum.
*
* @param \Illuminate\Http\Request $request
* @param \App\Models\Topic $id
*
* @return \Illuminate\Http\RedirectResponse
*/
public function editTopic(Request $request, $id)
@@ -275,9 +262,7 @@ class TopicController extends Controller
/**
* Close The Topic.
*
* @param \Illuminate\Http\Request $request
* @param \App\Models\Topic $id
*
* @return \Illuminate\Http\RedirectResponse
*/
public function closeTopic(Request $request, $id)
@@ -296,9 +281,7 @@ class TopicController extends Controller
/**
* Open The Topic.
*
* @param \Illuminate\Http\Request $request
* @param \App\Models\Topic $id
*
* @return \Illuminate\Http\RedirectResponse
*/
public function openTopic(Request $request, $id)
@@ -317,11 +300,9 @@ class TopicController extends Controller
/**
* Delete The Topic and The Posts.
*
* @param \Illuminate\Http\Request $request
* @param \App\Models\Topic $id
*
* @throws \Exception
*
* @return \Illuminate\Http\RedirectResponse
*/
public function deleteTopic(Request $request, $id)