mirror/UNIT3D-Community-Edition
1
0
Fork 0
mirror of https://github.com/HDInnovations/UNIT3D-Community-Edition.git synced 2026-04-23 11:39:19 -05:00
Code Issues Packages Projects Releases Wiki Activity

(Update) UserController.php (#2161)

Browse Source 
- Eliminate possible race condition, clear temporary files after use, parameterize paths, amalgamate sql queries.
This commit is contained in:
innocente205
2022-03-15 20:51:29 +07:00
committed by GitHub
parent f3a15237ba
commit 52e3c53661
1 changed files with 41 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/Http/Controllers/UserController.php
+41 -20
View File
@@ -1905,12 +1905,12 @@ class UserController extends Controller
$user = User::where('username', '=', $username)->firstOrFail();
\abort_unless($request->user()->id == $user->id, 403);
// Define Dir Folder
$path = \getcwd().'/files/tmp_zip/';
// Define zip Folder
$zipPath = \getcwd().'/files/tmp_zip/';
// Check Directory exists
if (! File::isDirectory($path)) {
File::makeDirectory($path, 0755, true, true);
if (! File::isDirectory($zipPath)) {
File::makeDirectory($zipPath, 0755, true, true);
}
// Zip File Name
@@ -1920,59 +1920,80 @@ class UserController extends Controller
$zipArchive = new ZipArchive();
// Get Users History
$historyTorrents = History::where('user_id', '=', $user->id)->pluck('torrent_id');
$historyTorrents = History::with(['torrent' => function ($query) {
$query->select('id', 'name', 'file_name', 'info_hash', 'slug');
}])
->where('user_id', '=', $user->id)->get('info_hash');
if ($zipArchive->open($path.'/'.$zipFileName, ZipArchive::CREATE) === true) {
if ($zipArchive->open($zipPath.$zipFileName, ZipArchive::CREATE) === true) {
// Match History Results To Torrents
$failCSV = '"Name","URL","ID","info_hash"
';
$failCount = 0;
foreach ($historyTorrents as $historyTorrent) {
// Get Torrent
$torrent = Torrent::withAnyStatus()
->where('id', '=', $historyTorrent)
->first();
if (! isset($historyTorrent->torrent->id)) {
Log::warning("History info_hash $historyTorrent->info_hash has no torrent table entry.");
continue;
}
$torrent = $historyTorrent->torrent;
// Define The Torrent Filename
// Define The Torrent Path and Filename
$tmpPath = \getcwd().'/files/tmp/'.$user->id.'/';
if (! is_dir($tmpPath)) {
mkdir($tmpPath, 0700, true);
}
$tmpFileName = \sprintf('%s.torrent', $torrent->slug);
// Define the torrent file path
$torrentPath = getcwd().'/files/torrents/';
// The Torrent File Exist?
if (! \file_exists(\getcwd().'/files/torrents/'.$torrent->file_name)) {
if (! \is_file($torrentPath.$torrent->file_name)) {
$failCSV .= '"'.$torrent->name.'","'.\route('torrent', ['id' => $torrent->id]).'","'.$torrent->id.'","'.$historyTorrent.'"
';
$failCount++;
} else {
// Delete The Last Torrent Tmp File If Exist
if (\file_exists(\getcwd().'/files/tmp/'.$tmpFileName)) {
\unlink(\getcwd().'/files/tmp/'.$tmpFileName);
if (\is_file($tmpPath.$tmpFileName)) {
\unlink($tmpPath.$tmpFileName);
}
// Get The Content Of The Torrent
$dict = Bencode::bdecode(\file_get_contents(\getcwd().'/files/torrents/'.$torrent->file_name));
$dict = Bencode::bdecode(\file_get_contents($torrentPath.$torrent->file_name));
// Set the announce key and add the user passkey
$dict['announce'] = \route('announce', ['passkey' => $user->passkey]);
// Remove Other announce url
unset($dict['announce-list']);
$fileToDownload = Bencode::bencode($dict);
\file_put_contents(\getcwd().'/files/tmp/'.$tmpFileName, $fileToDownload);
\file_put_contents($tmpPath.$tmpFileName, $fileToDownload);
// Add Files To ZipArchive
$zipArchive->addFile(\getcwd().'/files/tmp/'.$tmpFileName, $tmpFileName);
$zipArchive->addFile($tmpPath.$tmpFileName, $tmpFileName);
}
}
if ($failCount > 0) {
$CSVtmpName = \sprintf('%s.zip', $user->username).'-missingTorrentFiles.CSV';
\file_put_contents(\getcwd().'/files/tmp/'.$CSVtmpName, $failCSV);
$zipArchive->addFile(\getcwd().'/files/tmp/'.$CSVtmpName, 'missingTorrentFiles.CSV');
\file_put_contents($tmpPath.$CSVtmpName, $failCSV);
$zipArchive->addFile($tmpPath.$CSVtmpName, 'missingTorrentFiles.CSV');
}
// Close ZipArchive
$zipArchive->close();
}
$zipFile = $path.'/'.$zipFileName;
// Delete temporary files and directory
if (! empty($tmpPath) && is_dir($tmpPath)) {
$dirObj = new \RecursiveDirectoryIterator($tmpPath, \RecursiveDirectoryIterator::SKIP_DOTS);
$files = new \RecursiveIteratorIterator($dirObj, \RecursiveIteratorIterator::CHILD_FIRST);
foreach ($files as $filePath) {
$filePath->isDir() && ! $filePath->isLink() ? rmdir($filePath->getPathname()) : unlink($filePath->getPathname());
}
rmdir($tmpPath);
}
$zipFile = $zipPath.$zipFileName;
if (\file_exists($zipFile)) {
return \response()->download($zipFile)->deleteFileAfterSend(true);