mirror/UNIT3D-Community-Edition
1
0
Fork 0
mirror of https://github.com/HDInnovations/UNIT3D-Community-Edition.git synced 2026-04-22 10:08:31 -05:00
Code Issues Packages Projects Releases Wiki Activity

refactor: if / else / elseif statements

Browse Source 
- Change If Else Value Assign To Early Return
- Change Nested Ifs To Early Return
- Remove Always Else
This commit is contained in:
HDVinnie
2020-02-12 12:34:34 -05:00
parent 8607387023
commit 611fcd6bc1
57 changed files with 1065 additions and 1341 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/Http/Controllers/PrivateMessageController.php
+13 -19
View File
@@ -103,10 +103,9 @@ class PrivateMessageController extends Controller
}
return view('pm.message', ['pm' => $pm, 'user' => $user]);
} else {
return redirect()->route('inbox')
->withErrors('What Are You Trying To Do Here!');
}
return redirect()->route('inbox')
->withErrors('What Are You Trying To Do Here!');
}
/**
@@ -171,16 +170,14 @@ class PrivateMessageController extends Controller
return redirect()->route('create', ['username' => $request->user()->username, 'id' => $request->user()->id])
->withErrors($v->errors());
} else {
$pm->save();
if ($dest == 'profile') {
return redirect()->route('users.show', ['username' => $recipient->username])
->withSuccess('Your PM Was Sent Successfully!');
}
return redirect()->route('inbox')
}
$pm->save();
if ($dest == 'profile') {
return redirect()->route('users.show', ['username' => $recipient->username])
->withSuccess('Your PM Was Sent Successfully!');
}
return redirect()->route('inbox')
->withSuccess('Your PM Was Sent Successfully!');
}
/**
@@ -221,12 +218,10 @@ class PrivateMessageController extends Controller
if ($v->fails()) {
return redirect()->route('inbox')
->withErrors($v->errors());
} else {
$pm->save();
return redirect()->route('inbox')
->withSuccess('Your PM Was Sent Successfully!');
}
$pm->save();
return redirect()->route('inbox')
->withSuccess('Your PM Was Sent Successfully!');
}
/**
@@ -252,10 +247,9 @@ class PrivateMessageController extends Controller
if ($dest == 'outbox') {
return redirect()->route('outbox')->withSuccess('PM Was Deleted Successfully!');
} else {
return redirect()->route('inbox')
->withSuccess('PM Was Deleted Successfully!');
}
return redirect()->route('inbox')
->withSuccess('PM Was Deleted Successfully!');
} else {
return redirect()->route('inbox')
->withErrors('What Are You Trying To Do Here!');