mirror/UNIT3D-Community-Edition
1
0
Fork 0
mirror of https://github.com/HDInnovations/UNIT3D-Community-Edition.git synced 2026-04-23 11:39:19 -05:00
Code Issues Packages Projects Releases Wiki Activity

refactor: simplify chatroom get echoes/audibles exist condition

Browse Source
This commit is contained in:
Roardom
2024-04-30 09:15:37 +00:00
parent 3762d6eb11
commit 837441d34e
2 changed files with 2 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/Http/Controllers/API/ChatController.php
+2 -2
View File
@@ -54,7 +54,7 @@ class ChatController extends Controller
{
$user = $request->user()->load(['echoes']);
if (!$user->echoes || (is_countable($user->echoes->toArray()) ? \count($user->echoes->toArray()) : 0) < 1) {
if ($user->echoes->isEmpty()) {
$userEcho = new UserEcho();
$userEcho->user_id = $request->user()->id;
$userEcho->room_id = 1;
@@ -69,7 +69,7 @@ class ChatController extends Controller
{
$user = $request->user()->load(['audibles']);
if (!$user->audibles || (is_countable($user->audibles->toArray()) ? \count($user->audibles->toArray()) : 0) < 1) {
if ($user->audibles->isEmpty()) {
$userAudible = new UserAudible();
$userAudible->user_id = $request->user()->id;
$userAudible->room_id = 1;
phpstan-baseline.neon
-10
View File
@@ -525,11 +525,6 @@ parameters:
count: 6
path: app/Http/Controllers/API/ChatController.php
-
message: "#^Else branch is unreachable because ternary operator condition is always true\\.$#"
count: 2
path: app/Http/Controllers/API/ChatController.php
-
message: "#^Method App\\\\Http\\\\Controllers\\\\API\\\\ChatController\\:\\:botMessages\\(\\) has parameter \\$botId with no type specified\\.$#"
count: 1
@@ -555,11 +550,6 @@ parameters:
count: 1
path: app/Http/Controllers/API/ChatController.php
-
message: "#^Negated boolean expression is always false\\.$#"
count: 2
path: app/Http/Controllers/API/ChatController.php
-
message: "#^Property App\\\\Models\\\\UserAudible\\:\\:\\$status \\(int\\) does not accept bool\\.$#"
count: 3