chore: adopt type hints

app/Http/Controllers/UserController.php

@@ -46,10 +46,8 @@ class UserController extends Controller
 {
     /**
      * Show A User.
-     *
-     * @param \App\Models\User $username
      */
-    public function show($username): \Illuminate\Contracts\View\Factory|\Illuminate\View\View
+    public function show(\App\Models\User $username): \Illuminate\Contracts\View\Factory|\Illuminate\View\View
     {
         $user = User::with(['privacy', 'history'])->withCount('torrents')->where('username', '=', $username)->firstOrFail();
 
@@ -115,10 +113,8 @@ class UserController extends Controller
 
     /**
      * User Followers.
-     *
-     * @param \App\Models\User $username
      */
-    public function followers($username): \Illuminate\Contracts\View\Factory|\Illuminate\View\View
+    public function followers(\App\Models\User $username): \Illuminate\Contracts\View\Factory|\Illuminate\View\View
     {
         $user = User::where('username', '=', $username)->firstOrFail();
         $results = Follow::with('user')->where('target_id', '=', $user->id)->latest()->paginate(25);
@@ -132,10 +128,8 @@ class UserController extends Controller
 
     /**
      * User Topics.
-     *
-     * @param \App\Models\User $username
      */
-    public function topics($username): \Illuminate\Contracts\View\Factory|\Illuminate\View\View
+    public function topics(\App\Models\User $username): \Illuminate\Contracts\View\Factory|\Illuminate\View\View
     {
         $user = User::where('username', '=', $username)->firstOrFail();
         $results = Topic::where('topics.first_post_user_id', '=', $user->id)->latest()->paginate(25);
@@ -149,10 +143,8 @@ class UserController extends Controller
 
     /**
      * User Posts.
-     *
-     * @param \App\Models\User $username
      */
-    public function posts($username): \Illuminate\Contracts\View\Factory|\Illuminate\View\View
+    public function posts(\App\Models\User $username): \Illuminate\Contracts\View\Factory|\Illuminate\View\View
     {
         $user = User::where('username', '=', $username)->firstOrFail();
         $results = Post::selectRaw('posts.id as id,posts.*')->with(['topic', 'user'])->leftJoin('topics', 'posts.topic_id', '=', 'topics.id')->where('posts.user_id', '=', $user->id)->orderBy('posts.created_at', 'desc')->paginate(25);
@@ -166,10 +158,8 @@ class UserController extends Controller
 
     /**
      * Edit Profile Form.
-     *
-     * @param \App\Models\User $username
      */
-    public function editProfileForm(Request $request, $username): \Illuminate\Contracts\View\Factory|\Illuminate\View\View
+    public function editProfileForm(Request $request, \App\Models\User $username): \Illuminate\Contracts\View\Factory|\Illuminate\View\View
     {
         $user = User::where('username', '=', $username)->firstOrFail();
 
@@ -181,11 +171,10 @@ class UserController extends Controller
     /**
      * Edit User Profile.
      *
-     * @param \App\Models\User $username
      *
      * @return \Illuminate\Http\RedirectResponse
      */
-    public function editProfile(Request $request, $username)
+    public function editProfile(Request $request, \App\Models\User $username)
     {
         $user = User::where('username', '=', $username)->firstOrFail();
 
@@ -233,10 +222,8 @@ class UserController extends Controller
 
     /**
      * User Account Settings.
-     *
-     * @param \App\Models\User $username
      */
-    public function settings(Request $request, $username): \Illuminate\Contracts\View\Factory|\Illuminate\View\View
+    public function settings(Request $request, \App\Models\User $username): \Illuminate\Contracts\View\Factory|\Illuminate\View\View
     {
         $user = User::where('username', '=', $username)->firstOrFail();
 
@@ -248,11 +235,10 @@ class UserController extends Controller
     /**
      * Change User Account Settings.
      *
-     * @param \App\Models\User $username
      *
      * @return \Illuminate\Http\RedirectResponse
      */
-    public function changeSettings(Request $request, $username)
+    public function changeSettings(Request $request, \App\Models\User $username)
     {
         $user = User::where('username', '=', $username)->firstOrFail();
 
@@ -298,10 +284,8 @@ class UserController extends Controller
 
     /**
      * User Security Settings.
-     *
-     * @param \App\Models\User $username
      */
-    public function security(Request $request, $username): \Illuminate\Contracts\View\Factory|\Illuminate\View\View
+    public function security(Request $request, \App\Models\User $username): \Illuminate\Contracts\View\Factory|\Illuminate\View\View
     {
         $user = User::where('username', '=', $username)->firstOrFail();
 
@@ -335,11 +319,10 @@ class UserController extends Controller
     /**
      * User Password Change.
      *
-     * @param \App\Models\User $username
      *
      * @return \Illuminate\Http\RedirectResponse
      */
-    protected function changePassword(Request $request, $username)
+    protected function changePassword(Request $request, \App\Models\User $username)
     {
         $user = User::where('username', '=', $username)->firstOrFail();
 
@@ -369,11 +352,10 @@ class UserController extends Controller
     /**
      * User Email Change.
      *
-     * @param \App\Models\User $username
      *
      * @return \Illuminate\Http\RedirectResponse
      */
-    protected function changeEmail(Request $request, $username)
+    protected function changeEmail(Request $request, \App\Models\User $username)
     {
         $user = User::where('username', '=', $username)->firstOrFail();
 
@@ -404,11 +386,9 @@ class UserController extends Controller
     /**
      * Change User Privacy Level.
      *
-     * @param \App\Models\User $username
      *
-     * @return \Illuminate\Http\RedirectResponse
      */
-    public function makePrivate(Request $request, $username)
+    public function makePrivate(Request $request, \App\Models\User $username): \Illuminate\Http\RedirectResponse
     {
         $user = User::where('username', '=', $username)->firstOrFail();
 
@@ -424,11 +404,9 @@ class UserController extends Controller
     /**
      * Change User Privacy Level.
      *
-     * @param \App\Models\User $username
      *
-     * @return \Illuminate\Http\RedirectResponse
      */
-    public function makePublic(Request $request, $username)
+    public function makePublic(Request $request, \App\Models\User $username): \Illuminate\Http\RedirectResponse
     {
         $user = User::where('username', '=', $username)->firstOrFail();
 
@@ -444,11 +422,9 @@ class UserController extends Controller
     /**
      * Change User Notification Setting.
      *
-     * @param \App\Models\User $username
      *
-     * @return \Illuminate\Http\RedirectResponse
      */
-    public function disableNotifications(Request $request, $username)
+    public function disableNotifications(Request $request, \App\Models\User $username): \Illuminate\Http\RedirectResponse
     {
         $user = User::where('username', '=', $username)->firstOrFail();
 
@@ -464,11 +440,9 @@ class UserController extends Controller
     /**
      * Change User Notification Setting.
      *
-     * @param \App\Models\User $username
      *
-     * @return \Illuminate\Http\RedirectResponse
      */
-    public function enableNotifications(Request $request, $username)
+    public function enableNotifications(Request $request, \App\Models\User $username): \Illuminate\Http\RedirectResponse
     {
         $user = User::where('username', '=', $username)->firstOrFail();
 
@@ -484,11 +458,9 @@ class UserController extends Controller
     /**
      * Change User Hidden Value.
      *
-     * @param \App\Models\User $username
      *
-     * @return \Illuminate\Http\RedirectResponse
      */
-    public function makeHidden(Request $request, $username)
+    public function makeHidden(Request $request, \App\Models\User $username): \Illuminate\Http\RedirectResponse
     {
         $user = User::where('username', '=', $username)->firstOrFail();
 
@@ -504,11 +476,9 @@ class UserController extends Controller
     /**
      * Change User Hidden Value.
      *
-     * @param \App\Models\User $username
      *
-     * @return \Illuminate\Http\RedirectResponse
      */
-    public function makeVisible(Request $request, $username)
+    public function makeVisible(Request $request, \App\Models\User $username): \Illuminate\Http\RedirectResponse
     {
         $user = User::where('username', '=', $username)->firstOrFail();
 
@@ -524,13 +494,11 @@ class UserController extends Controller
     /**
      * Change User PID.
      *
-     * @param \App\Models\User $username
      *
      * @throws \Exception
      *
-     * @return \Illuminate\Http\RedirectResponse
      */
-    public function changePID(Request $request, $username)
+    public function changePID(Request $request, \App\Models\User $username): \Illuminate\Http\RedirectResponse
     {
         $user = User::where('username', '=', $username)->firstOrFail();
 
@@ -548,11 +516,9 @@ class UserController extends Controller
     /**
      * User Other Privacy Change.
      *
-     * @param \App\Models\User $username
      *
-     * @return \Illuminate\Http\RedirectResponse
      */
-    protected function changeOther(Request $request, $username)
+    protected function changeOther(Request $request, \App\Models\User $username): \Illuminate\Http\RedirectResponse
     {
         $user = User::where('username', '=', $username)->firstOrFail();
 
@@ -583,11 +549,9 @@ class UserController extends Controller
     /**
      * User Request Privacy Change.
      *
-     * @param \App\Models\User $username
      *
-     * @return \Illuminate\Http\RedirectResponse
      */
-    protected function changeRequest(Request $request, $username)
+    protected function changeRequest(Request $request, \App\Models\User $username): \Illuminate\Http\RedirectResponse
     {
         $user = User::where('username', '=', $username)->firstOrFail();
 
@@ -618,11 +582,9 @@ class UserController extends Controller
     /**
      * User Achievement Privacy Change.
      *
-     * @param \App\Models\User $username
      *
-     * @return \Illuminate\Http\RedirectResponse
      */
-    protected function changeAchievement(Request $request, $username)
+    protected function changeAchievement(Request $request, \App\Models\User $username): \Illuminate\Http\RedirectResponse
     {
         $user = User::where('username', '=', $username)->firstOrFail();
 
@@ -653,11 +615,9 @@ class UserController extends Controller
     /**
      * User Forum Privacy Change.
      *
-     * @param \App\Models\User $username
      *
-     * @return \Illuminate\Http\RedirectResponse
      */
-    protected function changeForum(Request $request, $username)
+    protected function changeForum(Request $request, \App\Models\User $username): \Illuminate\Http\RedirectResponse
     {
         $user = User::where('username', '=', $username)->firstOrFail();
 
@@ -689,11 +649,9 @@ class UserController extends Controller
     /**
      * User Follower Privacy Change.
      *
-     * @param \App\Models\User $username
      *
-     * @return \Illuminate\Http\RedirectResponse
      */
-    protected function changeFollower(Request $request, $username)
+    protected function changeFollower(Request $request, \App\Models\User $username): \Illuminate\Http\RedirectResponse
     {
         $user = User::where('username', '=', $username)->firstOrFail();
 
@@ -724,11 +682,9 @@ class UserController extends Controller
     /**
      * User Torrent Privacy Change.
      *
-     * @param \App\Models\User $username
      *
-     * @return \Illuminate\Http\RedirectResponse
      */
-    protected function changeTorrent(Request $request, $username)
+    protected function changeTorrent(Request $request, \App\Models\User $username): \Illuminate\Http\RedirectResponse
     {
         $user = User::where('username', '=', $username)->firstOrFail();
 
@@ -764,11 +720,9 @@ class UserController extends Controller
     /**
      * User Account Notification Change.
      *
-     * @param \App\Models\User $username
      *
-     * @return \Illuminate\Http\RedirectResponse
      */
-    protected function changeAccountNotification(Request $request, $username)
+    protected function changeAccountNotification(Request $request, \App\Models\User $username): \Illuminate\Http\RedirectResponse
     {
         $user = User::where('username', '=', $username)->firstOrFail();
 
@@ -800,11 +754,9 @@ class UserController extends Controller
     /**
      * User Following Notification Change.
      *
-     * @param \App\Models\User $username
      *
-     * @return \Illuminate\Http\RedirectResponse
      */
-    protected function changeFollowingNotification(Request $request, $username)
+    protected function changeFollowingNotification(Request $request, \App\Models\User $username): \Illuminate\Http\RedirectResponse
     {
         $user = User::where('username', '=', $username)->firstOrFail();
 
@@ -835,11 +787,9 @@ class UserController extends Controller
     /**
      * User BON Notification Change.
      *
-     * @param \App\Models\User $username
      *
-     * @return \Illuminate\Http\RedirectResponse
      */
-    protected function changeBonNotification(Request $request, $username)
+    protected function changeBonNotification(Request $request, \App\Models\User $username): \Illuminate\Http\RedirectResponse
     {
         $user = User::where('username', '=', $username)->firstOrFail();
 
@@ -870,11 +820,9 @@ class UserController extends Controller
     /**
      * User Subscription Notification Change.
      *
-     * @param \App\Models\User $username
      *
-     * @return \Illuminate\Http\RedirectResponse
      */
-    protected function changeSubscriptionNotification(Request $request, $username)
+    protected function changeSubscriptionNotification(Request $request, \App\Models\User $username): \Illuminate\Http\RedirectResponse
     {
         $user = User::where('username', '=', $username)->firstOrFail();
 
@@ -906,11 +854,9 @@ class UserController extends Controller
     /**
      * User Request Notification Change.
      *
-     * @param \App\Models\User $username
      *
-     * @return \Illuminate\Http\RedirectResponse
      */
-    protected function changeRequestNotification(Request $request, $username)
+    protected function changeRequestNotification(Request $request, \App\Models\User $username): \Illuminate\Http\RedirectResponse
     {
         $user = User::where('username', '=', $username)->firstOrFail();
 
@@ -947,11 +893,9 @@ class UserController extends Controller
     /**
      * User Torrent Notification Change.
      *
-     * @param \App\Models\User $username
      *
-     * @return \Illuminate\Http\RedirectResponse
      */
-    protected function changeTorrentNotification(Request $request, $username)
+    protected function changeTorrentNotification(Request $request, \App\Models\User $username): \Illuminate\Http\RedirectResponse
     {
         $user = User::where('username', '=', $username)->firstOrFail();
 
@@ -984,11 +928,9 @@ class UserController extends Controller
     /**
      * User Mention Notification Change.
      *
-     * @param \App\Models\User $username
      *
-     * @return \Illuminate\Http\RedirectResponse
      */
-    protected function changeMentionNotification(Request $request, $username)
+    protected function changeMentionNotification(Request $request, \App\Models\User $username): \Illuminate\Http\RedirectResponse
     {
         $user = User::where('username', '=', $username)->firstOrFail();
 
@@ -1023,11 +965,9 @@ class UserController extends Controller
     /**
      * User Forum Notification Change.
      *
-     * @param \App\Models\User $username
      *
-     * @return \Illuminate\Http\RedirectResponse
      */
-    protected function changeForumNotification(Request $request, $username)
+    protected function changeForumNotification(Request $request, \App\Models\User $username): \Illuminate\Http\RedirectResponse
     {
         $user = User::where('username', '=', $username)->firstOrFail();
 
@@ -1058,11 +998,9 @@ class UserController extends Controller
     /**
      * User Profile Privacy Change.
      *
-     * @param \App\Models\User $username
      *
-     * @return \Illuminate\Http\RedirectResponse
      */
-    protected function changeProfile(Request $request, $username)
+    protected function changeProfile(Request $request, \App\Models\User $username): \Illuminate\Http\RedirectResponse
     {
         $user = User::where('username', '=', $username)->firstOrFail();
 
@@ -1106,11 +1044,9 @@ class UserController extends Controller
     /**
      * Change User RID.
      *
-     * @param \App\Models\User $username
      *
-     * @return \Illuminate\Http\RedirectResponse
      */
-    public function changeRID(Request $request, $username)
+    public function changeRID(Request $request, \App\Models\User $username): \Illuminate\Http\RedirectResponse
     {
         $user = User::where('username', '=', $username)->firstOrFail();
 
@@ -1126,11 +1062,9 @@ class UserController extends Controller
     /**
      * Change User API Token.
      *
-     * @param \App\Models\User $username
      *
-     * @return \Illuminate\Http\RedirectResponse
      */
-    public function changeApiToken(Request $request, $username)
+    public function changeApiToken(Request $request, \App\Models\User $username): \Illuminate\Http\RedirectResponse
     {
         $user = User::where('username', '=', $username)->firstOrFail();
 
@@ -1145,10 +1079,8 @@ class UserController extends Controller
 
     /**
      * User Privacy Settings.
-     *
-     * @param \App\Models\User $username
      */
-    public function privacy(Request $request, $username): \Illuminate\Contracts\View\Factory|\Illuminate\View\View
+    public function privacy(Request $request, \App\Models\User $username): \Illuminate\Contracts\View\Factory|\Illuminate\View\View
     {
         $user = User::where('username', '=', $username)->firstOrFail();
 
@@ -1161,10 +1093,8 @@ class UserController extends Controller
 
     /**
      * User Notification Settings.
-     *
-     * @param \App\Models\User $username
      */
-    public function notification(Request $request, $username): \Illuminate\Contracts\View\Factory|\Illuminate\View\View
+    public function notification(Request $request, \App\Models\User $username): \Illuminate\Contracts\View\Factory|\Illuminate\View\View
     {
         $user = User::where('username', '=', $username)->firstOrFail();
 
@@ -1178,13 +1108,11 @@ class UserController extends Controller
     /**
      * Uses Input's To Put Together A Filtered View.
      *
-     * @param \App\Models\User $username
      *
      * @throws \Throwable
      *
-     * @return array
      */
-    public function myFilter(Request $request, $username)
+    public function myFilter(Request $request, \App\Models\User $username): string|bool
     {
         $user = User::where('username', '=', $username)->firstOrFail();
 
@@ -1703,10 +1631,8 @@ class UserController extends Controller
 
     /**
      * Get A Users Downloads (Fully Downloaded) Table.
-     *
-     * @param \App\Models\User $username
      */
-    public function downloads(Request $request, $username): \Illuminate\Contracts\View\Factory|\Illuminate\View\View
+    public function downloads(Request $request, \App\Models\User $username): \Illuminate\Contracts\View\Factory|\Illuminate\View\View
     {
         $user = User::where('username', '=', $username)->firstOrFail();
         if (($request->user()->id == $user->id || $request->user()->group->is_modo)) {
@@ -1770,10 +1696,8 @@ class UserController extends Controller
 
     /**
      * Get A Users Requested Table.
-     *
-     * @param \App\Models\User $username
      */
-    public function requested(Request $request, $username): \Illuminate\Contracts\View\Factory|\Illuminate\View\View
+    public function requested(Request $request, \App\Models\User $username): \Illuminate\Contracts\View\Factory|\Illuminate\View\View
     {
         $user = User::where('username', '=', $username)->firstOrFail();
         if (($request->user()->id == $user->id || $request->user()->group->is_modo)) {
@@ -1800,10 +1724,8 @@ class UserController extends Controller
 
     /**
      * Get A Users Unsatisfieds Table.
-     *
-     * @param \App\Models\User $username
      */
-    public function unsatisfieds(Request $request, $username): \Illuminate\Contracts\View\Factory|\Illuminate\View\View
+    public function unsatisfieds(Request $request, \App\Models\User $username): \Illuminate\Contracts\View\Factory|\Illuminate\View\View
     {
         $user = User::where('username', '=', $username)->firstOrFail();
 
@@ -1844,10 +1766,8 @@ class UserController extends Controller
 
     /**
      * Get A Users History Table.
-     *
-     * @param \App\Models\User $username
      */
-    public function torrents(Request $request, $username): \Illuminate\Contracts\View\Factory|\Illuminate\View\View
+    public function torrents(Request $request, \App\Models\User $username): \Illuminate\Contracts\View\Factory|\Illuminate\View\View
     {
         $user = User::where('username', '=', $username)->firstOrFail();
 
@@ -1874,10 +1794,8 @@ class UserController extends Controller
 
     /**
      * Get A Users Graveyard Resurrections.
-     *
-     * @param \App\Models\User $username
      */
-    public function resurrections(Request $request, $username): \Illuminate\Contracts\View\Factory|\Illuminate\View\View
+    public function resurrections(Request $request, \App\Models\User $username): \Illuminate\Contracts\View\Factory|\Illuminate\View\View
     {
         $user = User::where('username', '=', $username)->firstOrFail();
         \abort_unless($request->user()->group->is_modo || $request->user()->id == $user->id, 403);
@@ -1893,10 +1811,8 @@ class UserController extends Controller
 
     /**
      * Get A User Uploads.
-     *
-     * @param \App\Models\User $username
      */
-    public function uploads(Request $request, $username): \Illuminate\Contracts\View\Factory|\Illuminate\View\View
+    public function uploads(Request $request, \App\Models\User $username): \Illuminate\Contracts\View\Factory|\Illuminate\View\View
     {
         $user = User::where('username', '=', $username)->firstOrFail();
         if ($request->user()->id == $user->id || $request->user()->group->is_modo) {
@@ -1932,10 +1848,8 @@ class UserController extends Controller
 
     /**
      * Get A Users Active Table.
-     *
-     * @param \App\Models\User $username
      */
-    public function active(Request $request, $username): \Illuminate\Contracts\View\Factory|\Illuminate\View\View
+    public function active(Request $request, \App\Models\User $username): \Illuminate\Contracts\View\Factory|\Illuminate\View\View
     {
         $user = User::where('username', '=', $username)->firstOrFail();
 
@@ -1965,10 +1879,8 @@ class UserController extends Controller
 
     /**
      * Get A Users Seeds Table.
-     *
-     * @param \App\Models\User $username
      */
-    public function seeds(Request $request, $username): \Illuminate\Contracts\View\Factory|\Illuminate\View\View
+    public function seeds(Request $request, \App\Models\User $username): \Illuminate\Contracts\View\Factory|\Illuminate\View\View
     {
         $user = User::where('username', '=', $username)->firstOrFail();
 
@@ -1997,10 +1909,8 @@ class UserController extends Controller
 
     /**
      * Get A Users Bans.
-     *
-     * @param \App\Models\User $username
      */
-    public function getBans(Request $request, $username): \Illuminate\Contracts\View\Factory|\Illuminate\View\View
+    public function getBans(Request $request, \App\Models\User $username): \Illuminate\Contracts\View\Factory|\Illuminate\View\View
     {
         \abort_unless($request->user()->group->is_modo, 403);
 
@@ -2015,10 +1925,8 @@ class UserController extends Controller
 
     /**
      * Download All History Torrents.
-     *
-     * @param \App\Models\User $username
      */
-    public function downloadHistoryTorrents(Request $request, $username): \Illuminate\Http\RedirectResponse|\Symfony\Component\HttpFoundation\BinaryFileResponse
+    public function downloadHistoryTorrents(Request $request, \App\Models\User $username): \Illuminate\Http\RedirectResponse|\Symfony\Component\HttpFoundation\BinaryFileResponse
     {
         //  Extend The Maximum Execution Time
         \set_time_limit(1200);
@@ -2104,10 +2012,8 @@ class UserController extends Controller
     /**
      * Accept Site Rules.
      *
-     *
-     * @return void
      */
-    public function acceptRules(Request $request)
+    public function acceptRules(Request $request): void
     {
         $user = $request->user();
         $user->read_rules = 1;
@@ -2116,10 +2022,8 @@ class UserController extends Controller
 
     /**
      * Flushes own Peers.
-     *
-     * @param \App\Models\User $username
      */
-    public function flushOwnGhostPeers(Request $request, $username): \Illuminate\Http\RedirectResponse
+    public function flushOwnGhostPeers(Request $request, \App\Models\User $username): \Illuminate\Http\RedirectResponse
     {
         // Authorized User
         $user = User::where('username', '=', $username)->firstOrFail();
@@ -2159,12 +2063,8 @@ class UserController extends Controller
 
     /**
      * Get A Users Active Table by IP and Port.
-     *
-     * @param \App\Models\User $username
-     * @param \App\Models\Peer $ip
-     * @param \App\Models\Peer $port
      */
-    public function activeByClient(Request $request, $username, $ip, $port): \Illuminate\Contracts\View\Factory|\Illuminate\View\View
+    public function activeByClient(Request $request, \App\Models\User $username, \App\Models\Peer $ip, \App\Models\Peer $port): \Illuminate\Contracts\View\Factory|\Illuminate\View\View
     {
         $user = User::where('username', '=', $username)->firstOrFail();