refactor: use moderation status enum and cast

For consistency and less magic numbers hard coded everywhere.
This commit is contained in:
Roardom
2025-02-20 20:50:08 +00:00
parent 51937c897e
commit a447269552
46 changed files with 191 additions and 144 deletions
+4 -8
View File
@@ -21,6 +21,7 @@ use App\DTO\AnnounceGroupDTO;
use App\DTO\AnnounceQueryDTO;
use App\DTO\AnnounceTorrentDTO;
use App\DTO\AnnounceUserDTO;
use App\Enums\ModerationStatus;
use App\Exceptions\TrackerException;
use App\Jobs\ProcessAnnounce;
use App\Models\BlacklistClient;
@@ -42,11 +43,6 @@ use Illuminate\Support\Facades\Redis;
final class AnnounceController extends Controller
{
// Torrent Moderation Codes
protected const int PENDING = 0;
protected const int REJECTED = 2;
protected const int POSTPONED = 3;
// Announce Intervals
private const int MIN = 1_800;
private const int MAX = 3_600;
@@ -412,17 +408,17 @@ final class AnnounceController extends Controller
}
// If Torrent Is Pending Moderation Return Error to Client
if ($torrent->status === self::PENDING) {
if ($torrent->status === ModerationStatus::PENDING) {
throw new TrackerException(151, [':status' => 'PENDING In Moderation']);
}
// If Torrent Is Rejected Return Error to Client
if ($torrent->status === self::REJECTED) {
if ($torrent->status === ModerationStatus::REJECTED) {
throw new TrackerException(151, [':status' => 'REJECTED In Moderation']);
}
// If Torrent Is Postponed Return Error to Client
if ($torrent->status === self::POSTPONED) {
if ($torrent->status === ModerationStatus::POSTPONED) {
throw new TrackerException(151, [':status' => 'POSTPONED In Moderation']);
}