58 Commits

Author SHA1 Message Date
Roardom 8b27413fe8 refactor: make laravel eloquent models final
We never plan to extend a model, and value composition over inheritance. We need to add the AllowDynamicProperties warning to prevent PHPStan errors that arise with pivot relations (https://www.github.com/larastan/larastan/issues/2256).
2025-10-29 10:19:39 +00:00
Roardom 3988eaaf70 update: model phpdocs
- `use` the relation types
- Use sentence case
- Write better summaries similar to laravel's documentation (don't just repeat the type and the model)
2025-09-20 01:35:37 +00:00
Roardom 2861c61401 refactor: remove forum getPermission() function 2025-09-18 20:28:09 +00:00
Roardom 872d28d9c0 fix: larastan relations 2024-08-09 07:33:56 +00:00
HDVinnie 3ad3bb992b PHP Style Change (Laravel Pint CI) 2024-07-19 03:43:14 +00:00
HDVinnie 8ad0097fc9 fix: HasFactory types 2024-07-18 23:42:13 -04:00
Roardom b86475a732 add: strict types to all files 2024-05-23 13:58:29 +00:00
Roardom 6e5b3d9e3b refactor: use scope for forum authorization 2024-02-25 10:23:56 +00:00
Roardom 4311507870 refactor: rename permissions to forum_permissions 2024-02-25 06:21:41 +00:00
Roardom 7490a7a39e refactor: forum notification triggers 2024-02-13 22:50:57 +00:00
Roardom 686f1560ca update: separate forum categories into their own model 2024-02-12 07:39:52 +00:00
Roardom 834d438281 update: normalize forums a little more
We already make most of these queries anyways, and we'll need these foriegn keys when implementing future forum features like 'catch up'.
2024-02-09 16:44:52 +00:00
HDVinnie 8a03bec818 add: model docblocks
- this resolves some larastan property issues but in return has revealed quite a few issues with our castings and such. baseline has been regenerated so we can work through them. The properties in docblocks are in order and match everything in DB schema wise.
2024-02-07 16:39:43 -05:00
Roardom 0ef7cc235a fix: phpstan level 7 controller errors 2024-01-07 17:13:20 +00:00
Roardom f2066f4441 fix: add type hints to models 2023-08-26 07:43:07 +00:00
Roardom c4fccde317 fix: various larastan model issues 2023-08-25 04:21:38 +00:00
Roardom 7180f33edb add: forum category breadcrumb 2023-07-29 08:36:39 +00:00
Roardom b6b4313bdc update: various database performance improvements
Use eager loading where necessary and add a few indexes. The existing index on private_messages for sender_id and read was probably a typo and intended for receiver_id. The first 3 tables indexes are added to are used for queries ran on every page load: namely the new pm, new notification and warnings indicator in the navbar. Additionally, another index on genre_movie proved useful for finding all the genres when given a movie id. Perhaps, another index for finding all movies within a genre would be good as well, but will leave that for a future optimization if deemed necessary.
2023-07-17 00:21:08 +00:00
Roardom 3b46c7819b refactor: use route model binding for user routes 2023-07-07 00:28:47 +00:00
Roardom 9d4789ba91 refactor: require whitespace before statements 2023-07-07 00:27:13 +00:00
Roardom 8824abd9d5 update: forums 2023-05-08 01:30:43 +00:00
Roardom f3297917bb update: use livewire for forums 2023-02-08 18:14:14 -06:00
HDVinnie 472c820f99 update: UNIT3D linting
- github action updated with new ruleset in pint.json
- codebase linted with new ruleset
- contributors can now run `./vendor/bin/pint`
- action workflow will auto correct any lint issues upon commit/opened pull request
2023-02-02 08:02:34 -05:00
HDVinnie 9f7ff35e07 PSR12 Linting 2023-01-08 21:11:15 +00:00
Roardom c0ffee86db refactor: move forum requests to form requests 2023-01-08 05:04:49 -06:00
HDVinnie 3320269329 fix: type hints 2022-01-11 18:53:55 -05:00
HDVinnie 98521378d2 chore: phpdoc blocks 2022-01-10 17:46:43 -05:00
HDVinnie dd19889ee6 Merge branch '6.x.x' into Code-Style 2022-01-10 17:03:50 -05:00
HDVinnie 5e01a26c88 optimize: whereIn and whereNotIn queries 2022-01-10 16:25:26 -05:00
HDVinnie ebb5b72c2b fix: model type hints 2022-01-08 16:26:53 -05:00
HDVinnie c68f1cf503 update: type hints 2022-01-08 15:54:38 -05:00
HDVinnie 97394c062f chore: adopt type hints 2022-01-07 23:35:33 -05:00
HDVinnie c5eaa04f32 cleanup: forum model 2020-12-28 23:49:15 -05:00
Laravel Shift fac1da0b42 Shift cleanup 2020-09-08 22:25:06 +00:00
Laravel Shift add31768f5 Shift to class based factories 2020-09-08 22:24:30 +00:00
HDVinnie 01093d711c Apply fixes from StyleCI
[ci skip] [skip ci]
2020-07-28 16:54:24 +00:00
HDVinnie a975116218 refactor: preslash simple functions
- Add pre-slash to short named functions to improve performance by almost 30%
-  @see https://stackoverflow.com/questions/55419673/php7-adding-a-slash-to-all-standard-php-functions-php-cs-fixer-rule
2020-07-22 15:09:37 -04:00
HDVinnie 41b617bb2e update: laravel 7 support 2020-07-19 17:33:50 -04:00
HDVinnie 3f688c0d65 Apply fixes from StyleCI
[ci skip] [skip ci]
2020-06-03 06:10:58 +00:00
HDVinnie b96511357b update: model doc blocks 2020-06-03 02:09:16 -04:00
HDVinnie bf76798bd3 refactor: nullable compare to null 2020-04-24 11:31:12 -04:00
HDVinnie f90936a430 Merge pull request #1207 from cbj4074/forum-category-tests
Forum category tests
2020-03-05 10:48:20 -05:00
Ben Johnson 9e7b98aa93 tests: Add ForumCategoryController tests 2020-03-05 09:50:05 -05:00
shlandturtle e3c6976aaf add: Send notifications instead of chat announce for posts at staff area 2020-03-05 07:12:43 +00:00
HDVinnie 6eaeb07fc1 refactor: simplify ifelse to ternary 2020-02-13 17:30:47 -05:00
HDVinnie e47afe4ab4 chore: styleci 2020-02-12 14:51:22 -05:00
HDVinnie 80c842e39c chore: update license block
- make styleci happy
2020-02-12 14:49:18 -05:00
HDVinnie dbb928f940 chore: update license block 2020-02-12 14:45:59 -05:00
HDVinnie 9a893662de Apply fixes from StyleCI
[ci skip] [skip ci]
2020-01-08 16:28:32 +00:00
HDVinnie ef0b9e0203 Apply fixes from StyleCI
[ci skip] [skip ci]
2019-11-13 14:36:38 +00:00