Commit Graph

81 Commits

Author SHA1 Message Date
Roardom
9d4789ba91 refactor: require whitespace before statements 2023-07-07 00:27:13 +00:00
Roardom
738bc7f2d1 refactor: single line delete queries 2023-07-07 00:26:17 +00:00
HDVinnie
5232781f03 Merge pull request #2840 from Roardom/code-cleanup-3
(Refactor) Code Cleanup
2023-06-19 20:14:57 -04:00
Roardom
177c59d88d refactor: swap firstOrFail() for sole() to enforce a single result 2023-06-19 23:18:40 +00:00
Roardom
b5493c5642 refactor: swap where('id', '=', ) for find() 2023-06-19 23:18:40 +00:00
HDVinnie
d3f3510011 remove: unused foreach keys 2023-06-19 10:18:48 -04:00
HDVinnie
3650900c97 update: lint
- not_operator_with_space to false
2023-02-03 16:01:29 -05:00
HDVinnie
472c820f99 update: UNIT3D linting
- github action updated with new ruleset in pint.json
- codebase linted with new ruleset
- contributors can now run `./vendor/bin/pint`
- action workflow will auto correct any lint issues upon commit/opened pull request
2023-02-02 08:02:34 -05:00
StyleCI Bot
e292545306 Apply fixes from StyleCI 2022-05-31 22:06:07 +00:00
Shift
be2d37ed6e Use Illuminate\Support\Carbon 2022-05-31 22:05:34 +00:00
HDVinnie
594b7864d9 refactor: adopt new helpers in laravel 9 2022-03-06 17:20:05 -05:00
HDVinnie
bdd63aa816 update: controllers 2022-02-28 05:06:55 -05:00
HDVinnie
d7cb337f5f chore: streamline query builder orderBy calls with asc and desc arguments 2022-01-08 03:34:17 -05:00
HDVinnie
77ec35bea5 chore: apply the laravel code style linter 2022-01-08 00:03:12 -05:00
HDVinnie
97394c062f chore: adopt type hints 2022-01-07 23:35:33 -05:00
HDVinnie
2a53cea216 refactor: newline after statement 2021-09-28 12:49:46 -04:00
HDVinnie
3407075214 refactor: better php8 usage
- Change simple property init and assign to constructor promotion
- Remove unused variable in catch()
- Change docs types to union types, where possible
2021-05-15 22:41:28 -04:00
HDVinnie
8a9d94e07a update: preslash simple functions
- performance
2020-12-31 12:41:46 -05:00
HDVinnie
90b3880dab update: strpos and substr functions
- strpos and substr functions calls that can be replaced with the str_* functions calls (introduced in PHP 8.0).
2020-12-30 22:55:44 -05:00
HDVinnie
18f299157e refactor: api chat controller 2020-12-30 01:20:40 -05:00
HDVinnie
2476770b10 cleanup: api chat controller 2020-12-28 23:11:30 -05:00
HDVinnie
de86488112 Apply fixes from StyleCI
[ci skip] [skip ci]
2020-12-18 05:20:06 +00:00
HDVinnie
f0cac4a7d9 fix: api chat controller 2020-12-18 00:02:07 -05:00
HDVinnie
467d31f10a refactor: constructor promotions 2020-12-17 23:25:50 -05:00
HDVinnie
8efb7b4c58 update: api chat controller
- condition that are already covered by earlier condition and thus has no effect
2020-12-03 00:09:14 -05:00
HDVinnie
f70452da1a refactor: 'substr(...)' replaced with 'strpos(...)'
- 'substr(...)' invokes additional memory allocation (more work for GC), which is not needed in the context. 'strpos(...)' will do the same job with CPU resources only.
2020-12-02 21:07:17 -05:00
HDVinnie
99fd793d3d refactor: rename param to match type 2020-09-04 13:33:20 -04:00
HDVinnie
0733269867 update: phpdoc blocks 2020-07-22 16:57:13 -04:00
HDVinnie
a975116218 refactor: preslash simple functions
- Add pre-slash to short named functions to improve performance by almost 30%
-  @see https://stackoverflow.com/questions/55419673/php7-adding-a-slash-to-all-standard-php-functions-php-cs-fixer-rule
2020-07-22 15:09:37 -04:00
HDVinnie
e7ccde0190 refactor: rename property to match type 2020-07-22 14:50:41 -04:00
HDVinnie
f69ecec866 refactor: code quality changes 2020-06-02 18:37:19 -04:00
HDVinnie
bf76798bd3 refactor: nullable compare to null 2020-04-24 11:31:12 -04:00
HDVinnie
78608a4666 refactor: space after sole ! operators
-  There should be a space after sole `!` operators
2020-04-14 22:31:48 -04:00
Ben Johnson
a6f606ed9f tests: Improve several tests 2020-02-21 17:51:22 -05:00
Ben Johnson
5db70a9ea8 tests: Flesh-out several more ChatController tests 2020-02-20 16:38:43 -05:00
Ben Johnson
837d84c82a tests: Add a couple more tests 2020-02-19 22:08:19 -05:00
HDVinnie
29cd6e8eb6 refactor: use identical over equal with same type 2020-02-16 21:04:19 -05:00
HDVinnie
6eaeb07fc1 refactor: simplify ifelse to ternary 2020-02-13 17:30:47 -05:00
HDVinnie
285ecfa38b refactor: count on null 2020-02-12 19:15:58 -05:00
HDVinnie
780e0c1f0e chore: update license block 2020-02-12 15:05:34 -05:00
HDVinnie
9a893662de Apply fixes from StyleCI
[ci skip] [skip ci]
2020-01-08 16:28:32 +00:00
HDVinnie
6b6ae583c5 (Fix) Multiple Routing Issues 🐛 2019-11-10 16:36:35 -05:00
HDVinnie
d889971834 Apply fixes from StyleCI
[ci skip] [skip ci]
2019-11-05 22:40:30 +00:00
HDVinnie
eed3b51c92 (Update) CRUDDY PT.7 🚀 2019-10-25 17:35:14 -04:00
HDVinnie
dc2cf66405 (Update) CRUDDY PT.3 🚀 2019-10-23 13:48:28 -04:00
Laravel Shift
4853105815 Shift to consistent, fluent response chains 2019-05-09 00:05:17 +00:00
HDVinnie
e0e1aa924b Apply fixes from StyleCI 2019-02-22 13:16:32 +00:00
HDVinnie
3c87845e54 (Update) Namespace models under App\Models 🚀 2019-02-22 08:15:41 -05:00
HDVinnie
92560ad681 (Fix) ChatController 🐛
- add missing variable operator.
- Use of undefined constant receiver_id - assumed 'receiver_id'.
2019-02-12 13:16:19 -05:00
HDVinnie
c9aadb8c5c Apply fixes from StyleCI 2019-02-11 07:47:06 +00:00