Commit Graph

10 Commits

Author SHA1 Message Date
HDVinnie 0850390860 (Update) Standardize Where Expressions 🚀
- using `Model::where('download', '=', 1)` over`Model::where('download', 1)`
- decided is easier for new devs to understand.
- thanks to @werrpy for helping with the regex to mass update.
2018-12-16 18:32:58 -05:00
HDVinnie 00bb324053 Apply fixes from StyleCI 2018-12-06 14:42:13 +00:00
HDVinnie e15a6b5782 (Update) Cleanup Group Model 2018-06-06 19:47:52 -04:00
Poppabear 2ca0b04b78 (Fix) Bug in Groups/Permissions (Read Body)
--- Issue ---
When you create a new group it never sets up any forums permissions for
that group. This was causing errors like

Trying to get property 'show_forum' of non-object ...

This is due to in code its trying to access a property of a null object,
this is fatal and cause the app to crash, this happens when the page
tries and loads permissions for that group/forum and the groups
permissions is a null object.

--- Fix ---
In the add() method of the Staff/GroupsController.php we create a
permissions object for each forum and associate it to the new groups id.

--- Views ---
When using traditional form inputs and passing that data through
the request object, you should name the inputs the same name as the
database columns. This will make it easier in code to just pass the
request data to the create/update operations.

--- Models ---
When using mass assignments like Model::create() and/or Model::update(),
we have to tell the model to not guard those columns. So by adding
`protected $guarded = ['id'];` to the Model we say Only guard the 'id'.

Also, try and avoid the `Raw` eloquent queries!

--- Controllers ---
Validation rules should be in here and not in the Model and should be
validated BEFORE the creation of the resource!

--- Reminder ---
The Model is strictly for interacting with the database.

The Controller handles the http/ajax requests

The View handles how to present the data to the users screen

The Repository/Concrete Classes are to handle the application specific
logic
2018-05-12 12:55:00 -04:00
HDVinnie d797066370 (Fix) Group Settings
- This closes #75
2018-03-07 11:42:40 -05:00
Hyleus 777bb63880 Change license to AGPL 2018-02-12 17:27:32 +01:00
HDVinnie 961ffa8f95 (Update) Groups System PT.1
- #75
- Add Breadcrumbs
- Added missing group permissions/options
- Update Migration
- Cleanup/Refactor
- Note this does not fully close issue noted above. There is more to be
done which will be finalized in (Update) Groups System PT.2
2017-12-27 14:59:05 -05:00
HDVinnie 77a8c2140a (Update) NOTICE OF LICENSE
- Updated Author Names To Match GitHub Usernames For Clarity.
2017-12-15 22:45:37 -05:00
poppabear8883 e58563c88e Reformatted per psr-2 coding standards 2017-12-12 21:50:27 -05:00
HDVinnie 5a32c2c38d (Release) UNIT3D v1.0
- BETA
- There are bugs and features not yet complete
- This is not recommended for production use
2017-12-10 21:06:18 -05:00