HDVinnie
f69ecec866
refactor: code quality changes
2020-06-02 18:37:19 -04:00
Fionera
be16f3dbf9
Remove call to load all Users from Bon Store
...
This creates a out-of-memory exception if not fixed
2020-05-15 16:03:13 +02:00
HDVinnie
8c8e2865b2
refactor: camel case function naming to underscore
2020-04-24 11:04:24 -04:00
HDVinnie
78608a4666
refactor: space after sole ! operators
...
- There should be a space after sole `!` operators
2020-04-14 22:31:48 -04:00
HDVinnie
46aa876c06
refactor: add literal separator to numbers
...
- This is for PHP7.4 + only
- Adds an `_` as thousands separator in numbers
2020-04-14 20:25:07 -04:00
Ben Johnson
f853b3310a
fix: Fix regression
...
57212ca263 introduced the following change:
https://github.com/HDInnovations/UNIT3D-Community-Edition/blob/52c3d557944f2cba286573df3fa42f617918ce4e/app/Http/Controllers/BonusController.php#L489
This broke Tipping as described in:
https://github.com/HDInnovations/UNIT3D-Community-Edition/issues/1193
2020-03-11 10:57:28 -04:00
Ben Johnson
a986681184
fix: Fix incorrect byte values
...
Aside from fixing the units, which mixed binary and metric
inadvertently, this commit adds an interface to a third-party library
that handles the conversion much more elegantly and provides flexibility
for future needs of a similar nature.
2020-03-06 13:24:23 -05:00
HDVinnie
a9574f2228
chore: phpdoc block cleanup
2020-03-05 11:23:49 -05:00
HDVinnie
408bfafc3e
Apply fixes from StyleCI
...
[ci skip] [skip ci]
2020-03-05 15:47:30 +00:00
HDVinnie
4b9c006a05
chore: phpdoc blocks cleanup
2020-03-05 10:46:14 -05:00
Ben Johnson
57212ca263
tests: Add BonusController tests
2020-02-28 10:57:28 -05:00
HDVinnie
605c337204
refactor: encapsed strings to sprintf
2020-02-17 13:52:20 -05:00
HDVinnie
b275e9ba82
refactor: combine nested if statements
...
### `Combine If Rector`
Merges nested if statements
```diff
class SomeClass {
public function run()
{
- if ($cond1) {
- if ($cond2) {
- return 'foo';
- }
+ if ($cond1 && $cond2) {
+ return 'foo';
}
}
}
```
2020-02-13 11:26:54 -05:00
HDVinnie
c8d953a3ad
Merge branch 'master' into development
2020-02-12 18:03:21 -05:00
HDVinnie
780e0c1f0e
chore: update license block
2020-02-12 15:05:34 -05:00
HDVinnie
611fcd6bc1
refactor: if / else / elseif statements
...
- Change If Else Value Assign To Early Return
- Change Nested Ifs To Early Return
- Remove Always Else
2020-02-12 12:34:34 -05:00
HDVinnie
740483ec86
(Revert) #1048 ⏪
...
- reverted until BON system is refactored.
2020-02-12 09:50:54 -05:00
HDVinnie
9a893662de
Apply fixes from StyleCI
...
[ci skip] [skip ci]
2020-01-08 16:28:32 +00:00
HDVinnie
e77bf65da0
Apply fixes from StyleCI
...
[ci skip] [skip ci]
2020-01-06 15:31:25 +00:00
innocente205
193beaa065
Update BonusController.php
2020-01-06 15:24:45 +07:00
HDVinnie
d889971834
Apply fixes from StyleCI
...
[ci skip] [skip ci]
2019-11-05 22:40:30 +00:00
HDVinnie
eed3b51c92
(Update) CRUDDY PT.7 🚀
2019-10-25 17:35:14 -04:00
HDVinnie
426b801eda
(Update) CRUDDY PT.5 🚀
2019-10-23 16:59:03 -04:00
HDVinnie
2979750a8f
(Update) CRUDDY PT.4 🚀
2019-10-23 14:49:39 -04:00
HDVinnie
dc2cf66405
(Update) CRUDDY PT.3 🚀
2019-10-23 13:48:28 -04:00
HDVinnie
9fc03ab492
(Update) CRUDDY PT.1 🚀
2019-10-22 14:29:58 -04:00
HDVinnie
7e52caf450
(Remove) Select2 ♻️
...
- closes #683
2019-05-29 12:03:57 -04:00
Morgan Wong
d4b9b7c2ef
(Fix) missing parameter in function 🐛
2019-05-22 11:59:39 +08:00
HDVinnie
761f3175e9
Apply fixes from StyleCI
...
[ci skip] [skip ci]
2019-05-18 17:13:15 +00:00
HDVinnie
ae35e64ff0
(Fix) BonusController 🐛
...
- import $user variable into subquery
2019-05-15 17:40:17 -04:00
Laravel Shift
4853105815
Shift to consistent, fluent response chains
2019-05-09 00:05:17 +00:00
Laravel Shift
97e88dd68b
Leverage injected request object
...
Laravel automatically injects the current Http [request object][1] to all Controller actions and Middleware. Leveraging this object improves consistency and testability.
[1]: https://laravel.com/docs/5.7/requests#accessing-the-request
2019-05-09 00:05:13 +00:00
HDVinnie
67339d7329
(Update) PHPDocs 🚀
2019-04-03 20:02:01 -04:00
HDVinnie
4abadd4d92
(Fix) BonusController 🐛
...
- forgot to remove some hangover from other branch
2019-03-25 15:06:13 -04:00
HDVinnie
c382aa5236
(Update) Refactor Validation Error/Info/Warning/Success Handeling 🚀
2019-03-25 13:53:41 -04:00
HDVinnie
8bb397c29c
(Update) Standardize Select Queries 🚀
2019-03-13 11:26:20 -04:00
HDVinnie
e0e1aa924b
Apply fixes from StyleCI
2019-02-22 13:16:32 +00:00
HDVinnie
3c87845e54
(Update) Namespace models under App\Models 🚀
2019-02-22 08:15:41 -05:00
singularity43
7ddf0112f6
(Update) BonusController
...
Remove robot icon.
2019-02-09 14:58:20 -05:00
HDVinnie
adc6494012
Apply fixes from StyleCI
2019-01-31 04:04:04 +00:00
singularity43
fdeff39d2e
(Update) BonusController
...
1: Seperate views (store,gift,etc)
2: Add new stats
3: Add notify checks.
2019-01-30 21:38:01 -05:00
singularity43
dab2daefe9
(Update) Bonus Tip Notifications
...
Attach amount to the notification. (per request).
2019-01-25 23:03:08 -05:00
singularity43
c39f0dfc10
(Update) Forum Addon / (Update) User History
...
Fix the last reply pull.
Yes, the form fields don't match but I kept it this way for code clarity (IE: you know update_at needs to be ordered by insertion timeline).
-
Pass forum attribute as type to Post (which may be extended)
-
As requested by user.
2019-01-24 21:55:16 -05:00
singularity43
5390026bfc
Merge branch 'Forums-Addons' of https://github.com/HDInnovations/UNIT3D into Forums-Addons
...
Need This Done.
2019-01-23 22:51:31 -05:00
singularity43
8421833cf5
(Update) BonusController
...
New notification support.
2019-01-23 22:02:01 -05:00
singularity43
d7db9fe45b
(Update) BonusController
...
Add support for post tipping.
2019-01-23 15:25:11 -05:00
HDVinnie
0850390860
(Update) Standardize Where Expressions 🚀
...
- using `Model::where('download', '=', 1)` over`Model::where('download', 1)`
- decided is easier for new devs to understand.
- thanks to @werrpy for helping with the regex to mass update.
2018-12-16 18:32:58 -05:00
HDVinnie
2f2c52328b
Apply fixes from StyleCI
2018-12-06 22:57:41 +00:00
HDVinnie
00bb324053
Apply fixes from StyleCI
2018-12-06 14:42:13 +00:00
HDVinnie
87563a2473
(Update) Refator Toastr Notifications
2018-11-12 11:14:41 -05:00