From 1f10b63c8b015e9a2527f79e15a7042feb2d2aca Mon Sep 17 00:00:00 2001
From: Pujit Mehrotra <pujit@lime-technology.com>
Date: Thu, 3 Apr 2025 09:20:55 -0400
Subject: [PATCH] fix(plugin): flaky masking of benign warning during pnpm
 install (#1313)

The masking logic has a different effect in TTY and non-TTY environments
bc pnpm will change the `install` reporter. Now, we:

- set `--reporter=append-only` for consistency
- replace the grep loop with `sed` to mask and redirect the benign
"Ignored build scripts" warning

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Refactor**
- Streamlined the background logging during dependency installations to
improve overall efficiency and reduce complexity. This update enhances
maintainability without any visible changes to the user experience.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
---
 .../source/dynamix.unraid.net/etc/rc.d/rc.unraid-api | 12 ++----------
 1 file changed, 2 insertions(+), 10 deletions(-)

diff --git a/plugin/source/dynamix.unraid.net/etc/rc.d/rc.unraid-api b/plugin/source/dynamix.unraid.net/etc/rc.d/rc.unraid-api
index 3632e017a..1471396cd 100755
--- a/plugin/source/dynamix.unraid.net/etc/rc.d/rc.unraid-api
+++ b/plugin/source/dynamix.unraid.net/etc/rc.d/rc.unraid-api
@@ -108,16 +108,8 @@ restore_pnpm_store() {
 # Output: Streams install progress and logs build script warnings
 run_pnpm_install() {
   local log_file="/var/log/unraid-api/build-scripts.log"
-  stdbuf -oL pnpm install --prod --prefer-offline 2>&1 | while IFS= read -r line; do
-    if echo "$line" | grep -q "Ignored build scripts:"; then
-      mkdir -p "$(dirname "$log_file")"
-      echo "Note: This warning is expected. Build scripts are intentionally ignored for security and performance reasons." > "$log_file"
-      echo "$line" >> "$log_file"
-      echo "Build scripts completed. See $log_file for details."
-    else
-      echo "$line"
-    fi
-  done
+  stdbuf -oL pnpm install --prod --prefer-offline --reporter=append-only 2>&1 | sed -e "/^╭ Warning/,/^╰/w $log_file" -e "/^╭ Warning/,/^╰/c\Build scripts completed. See $log_file for details."
+  echo "Note: This warning is expected. Build scripts are intentionally ignored for security and performance reasons." >> "$log_file"
 }
 
 # Installs production dependencies for the unraid-api using pnpm. Prefers offline mode.