From 27b33f0f95caf4c4a13c2801bdc2620cdbdcd962 Mon Sep 17 00:00:00 2001
From: Pujit Mehrotra <pujit@lime-technology.com>
Date: Thu, 3 Jul 2025 09:31:00 -0400
Subject: [PATCH] build: fix artifact retreival in plugin promotion workflow
 (#1458)

Tested via manual dispatch on #1456 via cli. results in:
```xml
<!DOCTYPE PLUGIN [
  <!ENTITY name "dynamix.unraid.net">
  <!ENTITY launch "Connect">
  <!ENTITY author "limetech">
  <!ENTITY version "2025.07.03.0623">
  <!ENTITY plugin_url "https://preview.dl.unraid.net/unraid-api/dynamix.unraid.net.plg">
  <!ENTITY source "/boot/config/plugins/dynamix.my.servers/&txz_name;">
  <!ENTITY txz_sha256 "2075cdb8206733f7f037fefdb004a2d719498d6d6d7f3872afd0682a40ceff28">
  <!ENTITY txz_url "https://preview.dl.unraid.net/unraid-api/tag/PR1456/dynamix.unraid.net-4.8.0-x86_64-24.txz">
  <!ENTITY txz_name "dynamix.unraid.net-4.8.0-x86_64-24.txz">
  <!ENTITY arch "x86_64">
  <!ENTITY build "24">
  <!ENTITY tag "PR1456">
  <!ENTITY api_version "4.8.0">
]>
```
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

* **Chores**
  * Updated workflow input descriptions for consistency.
  * Expanded job permissions to improve workflow capabilities.
  * Enhanced artifact download step with additional input options.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
---
 .github/workflows/push-staging-pr-on-close.yml | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/.github/workflows/push-staging-pr-on-close.yml b/.github/workflows/push-staging-pr-on-close.yml
index 38da6c1ee..83d83d2b1 100644
--- a/.github/workflows/push-staging-pr-on-close.yml
+++ b/.github/workflows/push-staging-pr-on-close.yml
@@ -7,11 +7,11 @@ on:
   workflow_dispatch:
     inputs:
       pr_number:
-        description: 'PR number to test with'
+        description: "PR number to test with"
         required: true
         type: string
       pr_merged:
-        description: 'Simulate merged PR'
+        description: "Simulate merged PR"
         required: true
         type: boolean
         default: true
@@ -22,6 +22,7 @@ jobs:
     runs-on: ubuntu-latest
     permissions:
       contents: read
+      actions: read
     steps:
       - name: Set Timezone
         uses: szenius/set-timezone@v2.0
@@ -45,6 +46,8 @@ jobs:
           path: connect-files
           pr: ${{ steps.pr_number.outputs.pr_number }}
           workflow_conclusion: success
+          workflow_search: true
+          search_artifacts: true
 
       - name: Update Downloaded Staging Plugin to New Date
         run: |
@@ -55,14 +58,14 @@ jobs:
             ls -la connect-files/
             exit 1
           fi
-          
+
           echo "Found plugin file: $plgfile"
           version=$(date +"%Y.%m.%d.%H%M")
           sed -i -E "s#(<!ENTITY version \").*(\">)#\1${version}\2#g" "${plgfile}" || exit 1
                 
           # Change the plugin url to point to staging
           url="https://preview.dl.unraid.net/unraid-api/dynamix.unraid.net.plg"
-          sed -i -E "s#(<!ENTITY pluginURL \").*(\">)#\1${url}\2#g" "${plgfile}" || exit 1
+          sed -i -E "s#(<!ENTITY plugin_url \").*?(\">)#\1${url}\2#g" "${plgfile}" || exit 1
           cat "${plgfile}"
           mkdir -p pr-release
           mv "${plgfile}" pr-release/dynamix.unraid.net.plg