From 9ce2fee380c4db1395f5d4df7f16ae6c57d1a748 Mon Sep 17 00:00:00 2001 From: Eli Bosley Date: Wed, 21 May 2025 10:32:21 -0400 Subject: [PATCH] fix: use some instead of every for connect detection --- .../resolvers/connect/connect-settings.service.ts | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/api/src/unraid-api/graph/resolvers/connect/connect-settings.service.ts b/api/src/unraid-api/graph/resolvers/connect/connect-settings.service.ts index 618d1d40d..6f2c135d7 100644 --- a/api/src/unraid-api/graph/resolvers/connect/connect-settings.service.ts +++ b/api/src/unraid-api/graph/resolvers/connect/connect-settings.service.ts @@ -56,8 +56,7 @@ export class ConnectSettingsService { } isConnectPluginInstalled(): boolean { - // logic ported from webguid - return ['/var/lib/pkgtools/packages/dynamix.unraid.net', '/usr/local/sbin/unraid-api'].every( + return ['/var/lib/pkgtools/packages/dynamix.unraid.net', '/usr/local/bin/unraid-api'].some( (path) => fileExistsSync(path) ); } @@ -319,7 +318,9 @@ export class ConnectSettingsService { * Computes the JSONForms schema definition for remote access settings. */ async remoteAccessSlice(): Promise { - const precondition = (await this.isSignedIn()) && (await this.isSSLCertProvisioned()); + const isSignedIn = await this.isSignedIn(); + const isSSLCertProvisioned = await this.isSSLCertProvisioned(); + const precondition = isSignedIn && isSSLCertProvisioned; /** shown when preconditions are not met */ const requirements: UIElement[] = [ @@ -332,11 +333,11 @@ export class ConnectSettingsService { items: [ { text: 'You are signed in to Unraid Connect', - status: await this.isSignedIn(), + status: isSignedIn, }, { text: 'You have provisioned a valid SSL certificate', - status: await this.isSSLCertProvisioned(), + status: isSSLCertProvisioned, }, ], },