fix: minor duplicate click handler and version resolver nullability issue

This commit is contained in:
Eli Bosley
2025-08-20 17:21:18 -04:00
parent f1c043fe5f
commit ac198d5d1a
3 changed files with 22 additions and 22 deletions

View File

@@ -46,6 +46,6 @@ export class InfoVersions extends Node {
@Field(() => CoreVersions, { description: 'Core system versions' })
core!: CoreVersions;
@Field(() => PackageVersions, { description: 'Software package versions' })
packages!: PackageVersions;
@Field(() => PackageVersions, { nullable: true, description: 'Software package versions' })
packages?: PackageVersions;
}

View File

@@ -25,19 +25,24 @@ export class VersionsResolver {
};
}
@ResolveField(() => PackageVersions)
async packages(): Promise<PackageVersions> {
const softwareVersions = await versions();
@ResolveField(() => PackageVersions, { nullable: true })
async packages(): Promise<PackageVersions | null> {
try {
const softwareVersions = await versions();
return {
openssl: softwareVersions.openssl,
node: softwareVersions.node,
npm: softwareVersions.npm,
pm2: softwareVersions.pm2,
git: softwareVersions.git,
nginx: softwareVersions.nginx,
php: softwareVersions.php,
docker: softwareVersions.docker,
};
return {
openssl: softwareVersions.openssl,
node: softwareVersions.node,
npm: softwareVersions.npm,
pm2: softwareVersions.pm2,
git: softwareVersions.git,
nginx: softwareVersions.nginx,
php: softwareVersions.php,
docker: softwareVersions.docker,
};
} catch (error) {
console.error('Failed to get package versions:', error);
return null;
}
}
}

View File

@@ -31,16 +31,12 @@ const handleIframeLoad = () => {
const handleClose = () => {
emit('close');
};
const openInNewTab = () => {
window.open(releaseNotesUrl.value, '_blank');
};
</script>
<template>
<Modal
:center-content="false"
max-width="max-w-[800px]"
max-width="max-w-6xl"
:open="open"
:show-close-x="true"
:t="t"
@@ -61,7 +57,7 @@ const openInNewTab = () => {
</div>
<!-- iframe for release notes -->
<div class="w-[calc(100%+3rem)] h-[475px] -mx-6 -my-6">
<div class="w-[calc(100%+3rem)] h-[75vh] max-h-[800px] -mx-6 -my-6">
<iframe
ref="iframeRef"
:src="releaseNotesUrl"
@@ -83,7 +79,6 @@ const openInNewTab = () => {
:href="releaseNotesUrl"
:icon="ArrowTopRightOnSquareIcon"
aria-label="View on Docs"
@click="openInNewTab"
>
Open in New Tab
</BrandButton>