mirror/api
1
0
Fork 0
mirror of https://github.com/unraid/api.git synced 2026-01-01 14:10:10 -06:00
Code Issues Packages Projects Releases Wiki Activity

fix: allow concurrent testing with a shared patcher instance

Browse Source
This commit is contained in:
Eli Bosley
2025-02-04 11:44:34 -05:00
parent 9d1442b2ee
commit c00789865c
1 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
api/src/unraid-api/unraid-file-modifier/modifications/__test__/generic-modification.spec.ts
View File

@@ -17,7 +17,6 @@ interface ModificationTestCase {
fileUrl: string; fileUrl: string;
fileName: string; fileName: string;
} }
let patcher: FileModification;
const getPathToFixture = (fileName: string) => resolve(__dirname, `__fixtures__/downloaded/${fileName}`); const getPathToFixture = (fileName: string) => resolve(__dirname, `__fixtures__/downloaded/${fileName}`);
const testCases: ModificationTestCase[] = [ const testCases: ModificationTestCase[] = [
@@ -78,7 +77,7 @@ const downloadOrRetrieveOriginalFile = async (filePath: string, fileUrl: string)
return await readFile(filePath, 'utf-8'); return await readFile(filePath, 'utf-8');
}; };
async function testModification(testCase: ModificationTestCase) { async function testModification(testCase: ModificationTestCase, patcher: FileModification) {
const fileName = basename(testCase.fileUrl); const fileName = basename(testCase.fileUrl);
const filePath = getPathToFixture(fileName); const filePath = getPathToFixture(fileName);
const originalContent = await downloadOrRetrieveOriginalFile(filePath, testCase.fileUrl); const originalContent = await downloadOrRetrieveOriginalFile(filePath, testCase.fileUrl);
@@ -106,7 +105,7 @@ async function testModification(testCase: ModificationTestCase) {
await expect(revertedContent).toMatch(originalContent); await expect(revertedContent).toMatch(originalContent);
} }
async function testInvalidModification(testCase: ModificationTestCase) { async function testInvalidModification(testCase: ModificationTestCase, patcher: FileModification) {
const mockLogger = { const mockLogger = {
log: vi.fn(), log: vi.fn(),
error: vi.fn(), error: vi.fn(),
@@ -120,7 +119,6 @@ async function testInvalidModification(testCase: ModificationTestCase) {
// @ts-expect-error - Testing invalid pregenerated patches // @ts-expect-error - Testing invalid pregenerated patches
patcher.getPregeneratedPatch = vi.fn().mockResolvedValue('I AM NOT A VALID PATCH'); patcher.getPregeneratedPatch = vi.fn().mockResolvedValue('I AM NOT A VALID PATCH');
const path = patcher.filePath;
const filePath = getPathToFixture(testCase.fileName); const filePath = getPathToFixture(testCase.fileName);
// @ts-expect-error - Testing invalid pregenerated patches // @ts-expect-error - Testing invalid pregenerated patches
@@ -133,13 +131,15 @@ async function testInvalidModification(testCase: ModificationTestCase) {
await patcher.rollback(); await patcher.rollback();
} }
describe.sequential('File modifications', () => { describe('File modifications', () => {
let patcher: FileModification;
test.each(testCases)(`$fileName modifier correctly applies to fresh install`, async (testCase) => { test.each(testCases)(`$fileName modifier correctly applies to fresh install`, async (testCase) => {
await testModification(testCase); await testModification(testCase, patcher);
}); });
test.each(testCases)(`$fileName modifier correctly handles invalid content`, async (testCase) => { test.each(testCases)(`$fileName modifier correctly handles invalid content`, async (testCase) => {
await testInvalidModification(testCase); await testInvalidModification(testCase, patcher);
}); });
afterEach(async () => { afterEach(async () => {