mirror/api
1
0
Fork 0
mirror of https://github.com/unraid/api.git synced 2025-12-31 21:49:57 -06:00
Code Issues Packages Projects Releases Wiki Activity

fix(my.servers): improve DNS resolution robustness for backup server (#1518)

Browse Source 
Add multiple fallback methods for DNS resolution when checking
backup.unraid.net

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

* **Bug Fixes**
* Improved reliability of DNS resolution checks for backup services,
reducing false error reports.
* Enhanced error messages to provide clearer guidance if DNS resolution
fails, including advice to check DNS settings in network configuration.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
This commit is contained in:
Eli Bosley
2025-07-15 11:33:21 -04:00
committed by GitHub
parent 441e1805c1
commit eecd9b1017
1 changed files with 24 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
plugin/source/dynamix.unraid.net/usr/local/emhttp/plugins/dynamix.my.servers/include/UpdateFlashBackup.php
View File

@@ -594,9 +594,31 @@ set_git_config('user.email', 'gitbot@unraid.net');
set_git_config('user.name', 'gitbot'); set_git_config('user.name', 'gitbot');
// ensure dns can resolve backup.unraid.net // ensure dns can resolve backup.unraid.net
if (! checkdnsrr("backup.unraid.net","A") ) { $dnsResolved = false;
// Try multiple DNS resolution methods
if (function_exists('dns_get_record')) {
$dnsRecords = dns_get_record("backup.unraid.net", DNS_A);
$dnsResolved = !empty($dnsRecords);
}
// Fallback to gethostbyname if dns_get_record fails
if (!$dnsResolved) {
$ip = gethostbyname("backup.unraid.net");
$dnsResolved = ($ip !== "backup.unraid.net");
}
// Final fallback to system nslookup
if (!$dnsResolved) {
$output = [];
$return_var = 0;
exec('nslookup backup.unraid.net 2>/dev/null', $output, $return_var);
$dnsResolved = ($return_var === 0 && !empty($output));
}
if (!$dnsResolved) {
$arrState['loading'] = ''; $arrState['loading'] = '';
$arrState['error'] = 'DNS is unable to resolve backup.unraid.net'; $arrState['error'] = 'DNS resolution failed for backup.unraid.net - PHP DNS functions (checkdnsrr, dns_get_record, gethostbyname) and system nslookup all failed to resolve the hostname. This indicates a DNS configuration issue on your Unraid server. Check your DNS settings in Settings > Network Settings.';
response_complete(406, array('error' => $arrState['error'])); response_complete(406, array('error' => $arrState['error']));
} }