mirror of
https://github.com/unraid/api.git
synced 2025-12-31 13:39:52 -06:00
fix(ui): notifications positioning regression (#1445)
Downgrades the `vue-sonner` dependency from `2.0.0` to `1.3.0` because the newer version relies on unocss under the hood, which can't pipe across the web component build/boundary without modifying our css plumbing. The older version relied on a `styles.css` stylesheet. That stylesheet also couldn't make it through our build pipeline, but since it was a single asset, I vendored it via `sonner.css`. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Bug Fixes** * Improved logic to prevent duplicate insertion of the toaster element in the page layout. * **Chores** * Downgraded the "vue-sonner" dependency to version ^1.3.0. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --- - To see the specific tasks where the Asana app for GitHub is being used, see below: - https://app.asana.com/0/0/1210640791480730
This commit is contained in:
@@ -10,7 +10,7 @@ export default class DefaultPageLayoutModification extends FileModification {
|
||||
public readonly filePath: string = '/usr/local/emhttp/plugins/dynamix/include/DefaultPageLayout.php';
|
||||
|
||||
private addToaster(source: string): string {
|
||||
if (source.includes('unraid-toaster')) {
|
||||
if (source.includes('uui-toaster')) {
|
||||
return source;
|
||||
}
|
||||
const insertion = `<uui-toaster rich-colors close-button position="<?= ($notify['position'] === 'center') ? 'top-center' : $notify['position'] ?>"></uui-toaster>`;
|
||||
|
||||
11
pnpm-lock.yaml
generated
11
pnpm-lock.yaml
generated
@@ -839,8 +839,8 @@ importers:
|
||||
specifier: ^2.6.0
|
||||
version: 2.6.0
|
||||
vue-sonner:
|
||||
specifier: ^2.0.0
|
||||
version: 2.0.0
|
||||
specifier: ^1.3.0
|
||||
version: 1.3.0
|
||||
devDependencies:
|
||||
'@ianvs/prettier-plugin-sort-imports':
|
||||
specifier: ^4.4.1
|
||||
@@ -11107,7 +11107,6 @@ packages:
|
||||
engines: {node: '>=0.6.0', teleport: '>=0.2.0'}
|
||||
deprecated: |-
|
||||
You or someone you depend on is using Q, the JavaScript Promise library that gave JavaScript developers strong feelings about promises. They can almost certainly migrate to the native JavaScript promise now. Thank you literally everyone for joining me in this bet against the odds. Be excellent to each other.
|
||||
|
||||
(For a CapTP with native promises, see @endo/eventual-send and @endo/captp)
|
||||
|
||||
qs@6.13.0:
|
||||
@@ -13116,8 +13115,8 @@ packages:
|
||||
peerDependencies:
|
||||
vue: ^3.2.0
|
||||
|
||||
vue-sonner@2.0.0:
|
||||
resolution: {integrity: sha512-nvlqGGWvxEv9UnKcZxsGdKpHrODEdv3CXAJF3er+1pLC03caJt2+v9HuWtRqlBQwUr1SFttsYuwVbpbEl05n4A==}
|
||||
vue-sonner@1.3.0:
|
||||
resolution: {integrity: sha512-jAodBy4Mri8rQjVZGQAPs4ZYymc1ywPiwfa81qU0fFl+Suk7U8NaOxIDdI1oBGLeQJqRZi/oxNIuhCLqsBmOwg==}
|
||||
|
||||
vue-template-compiler@2.7.16:
|
||||
resolution: {integrity: sha512-AYbUWAJHLGGQM7+cNTELw+KsOG9nl2CnSv467WobS5Cv9uk3wFcnr1Etsz2sEIHEZvw1U+o9mRlEO6QbZvUPGQ==}
|
||||
@@ -27305,7 +27304,7 @@ snapshots:
|
||||
'@vue/devtools-api': 6.6.4
|
||||
vue: 3.5.17(typescript@5.8.3)
|
||||
|
||||
vue-sonner@2.0.0: {}
|
||||
vue-sonner@1.3.0: {}
|
||||
|
||||
vue-template-compiler@2.7.16:
|
||||
dependencies:
|
||||
|
||||
@@ -61,7 +61,7 @@
|
||||
"marked": "^15.0.0",
|
||||
"reka-ui": "^2.1.1",
|
||||
"tailwind-merge": "^2.6.0",
|
||||
"vue-sonner": "^2.0.0"
|
||||
"vue-sonner": "^1.3.0"
|
||||
},
|
||||
"devDependencies": {
|
||||
"@ianvs/prettier-plugin-sort-imports": "^4.4.1",
|
||||
|
||||
Reference in New Issue
Block a user