mirror of
https://github.com/unraid/api.git
synced 2026-01-06 16:49:49 -06:00
Share names live as section headers in `emhttp/state/shares.ini`. However, periods in ini section headers typically denote nested hierarchy. This behavior is disabled in unraid's php setup, but cannot be disabled/configured in the api's current ini parser. So, we perform post-processing to reconcile nested objects into dot notation. Known issue: trailing and leading periods will not be treated as distinct from shares without them. i.e. `.share.name.` will conflict with `share.name`, `.share.name`, or `share.name.`. The last of the conflicting names will be used/exposed. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - New Features - Support shares with periods and emoji in their names across parsing and listings. - Bug Fixes - Fixed configuration parsing for section names containing periods to ensure affected shares load and display correctly. - Standardized reporting of encryption status for all shares. - Tests - Expanded coverage to validate parsing and retrieval of shares with special characters (periods and emoji), ensuring consistent behavior across modules. <!-- end of auto-generated comment: release notes by coderabbit.ai -->