From 0cad4b785c429fd4056b732f2a252e13e71fd545 Mon Sep 17 00:00:00 2001
From: Christopher Hiller <boneskull@boneskull.com>
Date: Thu, 12 Jan 2023 12:22:51 -0800
Subject: [PATCH] chore(typedoc-plugin-appium): rename some vars

---
 .../lib/converter/builtin-method-map.ts                   | 2 +-
 .../lib/converter/exec-method-map.ts                      | 8 ++++----
 packages/typedoc-plugin-appium/lib/converter/external.ts  | 2 +-
 .../typedoc-plugin-appium/lib/converter/method-map.ts     | 6 +++---
 4 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/packages/typedoc-plugin-appium/lib/converter/builtin-method-map.ts b/packages/typedoc-plugin-appium/lib/converter/builtin-method-map.ts
index 7cb51122a..5b77368af 100644
--- a/packages/typedoc-plugin-appium/lib/converter/builtin-method-map.ts
+++ b/packages/typedoc-plugin-appium/lib/converter/builtin-method-map.ts
@@ -82,7 +82,7 @@ export class BuiltinMethodMapConverter extends BaseConverter<BuiltinCommands> {
 
     const baseDriverRoutes = convertMethodMap({
       log: this.log,
-      methodMapRef: methodMap,
+      methodMapRefl: methodMap,
       parentRefl: baseDriverModuleRefl,
       methods: findAsyncMethodsInReflection(baseDriverClassRefl, this.knownMethods),
     });
diff --git a/packages/typedoc-plugin-appium/lib/converter/exec-method-map.ts b/packages/typedoc-plugin-appium/lib/converter/exec-method-map.ts
index 80abd2df7..06a356426 100644
--- a/packages/typedoc-plugin-appium/lib/converter/exec-method-map.ts
+++ b/packages/typedoc-plugin-appium/lib/converter/exec-method-map.ts
@@ -98,9 +98,9 @@ export function convertExecuteMethodMap({
     const requiredParams = convertRequiredCommandParams(paramsProp);
     const optionalParams = convertOptionalCommandParams(paramsProp);
 
-    const method = methods.get(command)?.method;
+    const methodRefl = methods.get(command)?.method;
 
-    if (strict && !method) {
+    if (strict && !methodRefl) {
       log.error(
         '(%s) No method found for command "%s" from script "%s"',
         parentRefl.name,
@@ -110,13 +110,13 @@ export function convertExecuteMethodMap({
       continue;
     }
 
-    const commentData = deriveComment(command, methods, method, comment);
+    const commentData = deriveComment(command, methods, methodRefl, comment);
 
     commandRefs.add(
       new ExecMethodData(log, command, script, {
         requiredParams,
         optionalParams,
-        refl: method,
+        refl: methodRefl,
         comment: commentData?.comment,
         commentSource: commentData?.commentSource,
         isPluginCommand,
diff --git a/packages/typedoc-plugin-appium/lib/converter/external.ts b/packages/typedoc-plugin-appium/lib/converter/external.ts
index 01fb7491b..fb88584df 100644
--- a/packages/typedoc-plugin-appium/lib/converter/external.ts
+++ b/packages/typedoc-plugin-appium/lib/converter/external.ts
@@ -241,7 +241,7 @@ export class ExternalConverter extends BaseConverter<ProjectCommands> {
     }
     return convertMethodMap({
       log: this.log,
-      methodMapRef: newMethodMapRefl,
+      methodMapRefl: newMethodMapRefl,
       parentRefl: classRefl,
       methods,
       knownMethods: this.knownMethods,
diff --git a/packages/typedoc-plugin-appium/lib/converter/method-map.ts b/packages/typedoc-plugin-appium/lib/converter/method-map.ts
index 262445537..d399b4e87 100644
--- a/packages/typedoc-plugin-appium/lib/converter/method-map.ts
+++ b/packages/typedoc-plugin-appium/lib/converter/method-map.ts
@@ -33,7 +33,7 @@ export interface ConvertMethodMapOpts {
   /**
    * A `MethodMap` object whose parent is `parentRefl`
    */
-  methodMapRef: MethodMapDeclarationReflection;
+  methodMapRefl: MethodMapDeclarationReflection;
   /**
    * All async methods in `parentRefl`
    */
@@ -60,7 +60,7 @@ export interface ConvertMethodMapOpts {
  */
 export function convertMethodMap({
   log,
-  methodMapRef,
+  methodMapRefl,
   parentRefl,
   methods,
   knownMethods = new Map(),
@@ -69,7 +69,7 @@ export function convertMethodMap({
 }: ConvertMethodMapOpts): RouteMap {
   const routes: RouteMap = new Map();
 
-  const routeProps = filterChildrenByKind(methodMapRef, ReflectionKind.Property);
+  const routeProps = filterChildrenByKind(methodMapRefl, ReflectionKind.Property);
 
   if (!routeProps.length) {
     log.warn('(%s) No routes found in MethodMap; skipping', parentRefl.name);