mirror/appium
1
0
Fork 0
mirror of https://github.com/appium/appium.git synced 2026-05-05 18:10:24 -05:00
Code Issues Packages Projects Releases Wiki Activity

Fix iOS id

Browse Source 
iOS must use weighted predicates or it'll return the wrong result when multiple
elements share the same id.

For example:
id('sign_in_label').click currently matches a static text and a button. The
static text does nothing, so we'd prefer to return an element that has
interactive abilities such as the button.

If someone wanted to match the static text using an id anyway, they could do
s_text resolve_id 'sign_in_label'
This commit is contained in:
bootstraponline
2013-09-06 13:59:38 -04:00
parent e06f798297
commit 4ef4449816
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/ios.js
+2 -2
View File
@@ -700,10 +700,10 @@ IOS.prototype.findUIElementOrElements = function(strategy, selector, ctx, many,
if (strings && strings.length >= 1) selector = strings[0][selector];
// Prefer an exact match. Some apps, such as uicatalog, don't use exact
// matches so contains is required.
command = ["var exact = au.mainApp.getFirstWithPredicate(\"name == '", selector,
command = ["var exact = au.mainApp.getFirstWithPredicateWeighted(\"name == '", selector,
"' || label == '", selector, "' || value == '", selector, "'\");"].join('');
command += ["exact && exact.status == 0 ? exact : au.mainApp.getFirstWith",
"Predicate(\"name contains[c] '", selector, "' || label contains[c] '",
"PredicateWeighted(\"name contains[c] '", selector, "' || label contains[c] '",
selector, "' || value contains[c] '", selector, "'\");"].join('');
} else {
command = ["au.getElement", ext, "ByType('", selector, "'", ctx,")"].join('');