mirror/appium
1
0
Fork 0
mirror of https://github.com/appium/appium.git synced 2026-02-14 05:50:00 -06:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #3733 from imurchie/isaac-android-release

Browse Source 
Use last coordinates for touch release
This commit is contained in:
Jonathan Lipps
2014-10-04 11:26:11 -07:00
parent 464c77722d 6d81a0f3fb
commit 8451da791d
1 changed files with 15 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
lib/devices/android/android-controller.js
View File

@@ -913,6 +913,21 @@ androidController.performTouch = function (gestures, cb) {
// the `longPress` and `tap` methods release on their own
gestures.pop();
}
if (actions[actions.length - 1] === 'release') {
// without coordinates, `release` uses the center of the screen, which,
// generally speaking, is not what we want
// therefore: loop backwards and use the last command with an element and/or
// offset coordinates
for (var i = actions.length - 2; i >= 0; i--) {
var opts = gestures[i].options || {};
if (opts.element || (opts.x && opts.y)) {
gestures[gestures.length - 1].options = _.clone(opts);
break;
}
}
}
var cycleThroughGestures = function (err, res) {
if (err) return cb(err);