chore(base-driver): remove mobileRotation as no references (#19379)

* chore(base-driver): remove mobileRotation as no references

* docs: remove unused endpoint

* test: fix test
This commit is contained in:
Kazuaki Matsuo
2023-11-06 23:12:11 -08:00
committed by GitHub
parent 1ae85d6e14
commit b83bd04265
5 changed files with 1 additions and 36 deletions
@@ -116,7 +116,6 @@ POST | `session/{sessionId}/appium/getPerformanceData` | returns the
POST | `session/{sessionId}/appium/device/press_keycode` | Press a particular key code on the device.
POST | `session/{sessionId}/appium/device/long_press_keycode` | Press and hold a particular key code on the device.
POST | `session/{sessionId}/appium/device/keyevent` | Send a key code to the device.
POST | `session/{sessionId}/appium/device/rotate` | Rotate the device in three dimensions.
GET | `session/{sessionId}/appium/device/current_activity` | Retrieve the current activity running on the device.
GET | `session/{sessionId}/appium/device/current_package` | Retrieve the current package running on the device.
POST | `session/{sessionId}/appium/device/install_app` | Install the given app onto the device.
@@ -568,16 +568,6 @@ const METHOD_MAP = /** @type {const} */ ({
deprecated: true,
},
},
'/session/:sessionId/appium/device/rotate': {
POST: {
command: 'mobileRotation',
payloadParams: {
required: ['x', 'y', 'radius', 'rotation', 'touchCount', 'duration'],
optional: ['element'],
},
deprecated: true,
},
},
'/session/:sessionId/appium/device/current_activity': {
GET: {command: 'getCurrentActivity', deprecated: true},
},
@@ -35,7 +35,7 @@ describe('Protocol', function () {
}
let hash = shasum.digest('hex').substring(0, 8);
// Modify the hash whenever the protocol has intentionally been modified.
hash.should.equal('484810b0');
hash.should.equal('6e93ad90');
});
});
@@ -71,7 +71,6 @@ import './general';
//rest.post('/wd/hub/session/:sessionId?/appium/device/press_keycode', controller.pressKeyCode);
//rest.post('/wd/hub/session/:sessionId?/appium/device/long_press_keycode', controller.longPressKeyCode);
//rest.post('/wd/hub/session/:sessionId?/appium/device/keyevent', controller.keyevent);
//rest.post('/wd/hub/session/:sessionId?/appium/device/rotate', controller.mobileRotation);
//rest.get('/wd/hub/session/:sessionId?/appium/device/current_activity', controller.getCurrentActivity);
//rest.post('/wd/hub/session/:sessionId?/appium/device/install_app', controller.installApp);
//rest.post('/wd/hub/session/:sessionId?/appium/device/remove_app', controller.removeApp);
-23
View File
@@ -1359,29 +1359,6 @@ export interface ExternalDriver<
*/
keyevent?(keycode: string | number, metastate?: string | number): Promise<void>;
/**
* Construct a rotation gesture? Unclear what this command does and it does not appear to be used
*
* @param x - the x coordinate of the rotation center
* @param y - the y coordinate of the rotation center
* @param radius - the radius of the rotation circle
* @param rotation - the rotation angle? idk
* @param touchCount - how many fingers to rotate
* @param elementId - if we're rotating around an element
*
* @deprecated Use setRotation instead
* @privateRemarks Not implemented in `appium-xcuitest-driver`
*/
mobileRotation?(
x: number,
y: number,
radius: number,
rotation: number,
touchCount: number,
duration: string,
elementId?: string
): Promise<void>;
/**
* Get the current activity name
*