diff --git a/packages/base-driver/docs/mjsonwp/protocol-methods.md b/packages/base-driver/docs/mjsonwp/protocol-methods.md index a4d3b5ad2..c6bc8c041 100644 --- a/packages/base-driver/docs/mjsonwp/protocol-methods.md +++ b/packages/base-driver/docs/mjsonwp/protocol-methods.md @@ -116,7 +116,6 @@ POST | `session/{sessionId}/appium/getPerformanceData` | returns the POST | `session/{sessionId}/appium/device/press_keycode` | Press a particular key code on the device. POST | `session/{sessionId}/appium/device/long_press_keycode` | Press and hold a particular key code on the device. POST | `session/{sessionId}/appium/device/keyevent` | Send a key code to the device. -POST | `session/{sessionId}/appium/device/rotate` | Rotate the device in three dimensions. GET | `session/{sessionId}/appium/device/current_activity` | Retrieve the current activity running on the device. GET | `session/{sessionId}/appium/device/current_package` | Retrieve the current package running on the device. POST | `session/{sessionId}/appium/device/install_app` | Install the given app onto the device. diff --git a/packages/base-driver/lib/protocol/routes.js b/packages/base-driver/lib/protocol/routes.js index 2801621eb..23eacf31c 100644 --- a/packages/base-driver/lib/protocol/routes.js +++ b/packages/base-driver/lib/protocol/routes.js @@ -568,16 +568,6 @@ const METHOD_MAP = /** @type {const} */ ({ deprecated: true, }, }, - '/session/:sessionId/appium/device/rotate': { - POST: { - command: 'mobileRotation', - payloadParams: { - required: ['x', 'y', 'radius', 'rotation', 'touchCount', 'duration'], - optional: ['element'], - }, - deprecated: true, - }, - }, '/session/:sessionId/appium/device/current_activity': { GET: {command: 'getCurrentActivity', deprecated: true}, }, diff --git a/packages/base-driver/test/unit/protocol/routes.spec.js b/packages/base-driver/test/unit/protocol/routes.spec.js index f4d95a3b1..0b9808397 100644 --- a/packages/base-driver/test/unit/protocol/routes.spec.js +++ b/packages/base-driver/test/unit/protocol/routes.spec.js @@ -35,7 +35,7 @@ describe('Protocol', function () { } let hash = shasum.digest('hex').substring(0, 8); // Modify the hash whenever the protocol has intentionally been modified. - hash.should.equal('484810b0'); + hash.should.equal('6e93ad90'); }); }); diff --git a/packages/fake-driver/lib/commands/index.ts b/packages/fake-driver/lib/commands/index.ts index 2a726aa18..250117c30 100644 --- a/packages/fake-driver/lib/commands/index.ts +++ b/packages/fake-driver/lib/commands/index.ts @@ -71,7 +71,6 @@ import './general'; //rest.post('/wd/hub/session/:sessionId?/appium/device/press_keycode', controller.pressKeyCode); //rest.post('/wd/hub/session/:sessionId?/appium/device/long_press_keycode', controller.longPressKeyCode); //rest.post('/wd/hub/session/:sessionId?/appium/device/keyevent', controller.keyevent); - //rest.post('/wd/hub/session/:sessionId?/appium/device/rotate', controller.mobileRotation); //rest.get('/wd/hub/session/:sessionId?/appium/device/current_activity', controller.getCurrentActivity); //rest.post('/wd/hub/session/:sessionId?/appium/device/install_app', controller.installApp); //rest.post('/wd/hub/session/:sessionId?/appium/device/remove_app', controller.removeApp); diff --git a/packages/types/lib/driver.ts b/packages/types/lib/driver.ts index 85c9781d8..5a3e0fde0 100644 --- a/packages/types/lib/driver.ts +++ b/packages/types/lib/driver.ts @@ -1359,29 +1359,6 @@ export interface ExternalDriver< */ keyevent?(keycode: string | number, metastate?: string | number): Promise; - /** - * Construct a rotation gesture? Unclear what this command does and it does not appear to be used - * - * @param x - the x coordinate of the rotation center - * @param y - the y coordinate of the rotation center - * @param radius - the radius of the rotation circle - * @param rotation - the rotation angle? idk - * @param touchCount - how many fingers to rotate - * @param elementId - if we're rotating around an element - * - * @deprecated Use setRotation instead - * @privateRemarks Not implemented in `appium-xcuitest-driver` - */ - mobileRotation?( - x: number, - y: number, - radius: number, - rotation: number, - touchCount: number, - duration: string, - elementId?: string - ): Promise; - /** * Get the current activity name *