mirror/appium
1
0
Fork 0
mirror of https://github.com/appium/appium.git synced 2026-02-14 05:50:00 -06:00
Code Issues Packages Projects Releases Wiki Activity

add comment about why we're doing dumb things with chromedriver

Browse Source
This commit is contained in:
Jonathan Lipps
2013-06-30 10:19:33 -07:00
parent 37150b594c
commit d82880ca6a
1 changed files with 3 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
app/chrome_android.js
View File

@@ -61,11 +61,6 @@ ChromeAndroid.prototype.startChromedriver = function(cb) {
this.proc.stdout.pipe(through(function(data) {
logger.info('[CHROMEDRIVER] ' + data.trim());
if (!alreadyReturned && data.indexOf("Started ChromeDriver") !== -1) {
this.chromedriverStarted = true;
alreadyReturned = true;
cb();
}
}));
this.proc.stderr.pipe(through(function(data) {
@@ -81,10 +76,11 @@ ChromeAndroid.prototype.startChromedriver = function(cb) {
this.onDie();
}.bind(this));
// chromedriver detects that it's not on a TTY and doesn't give any output
// to let us know it's started, so we just assume it started if it didn't
// exit
setTimeout(function() {
if (!alreadyReturned) {
logger.info("We didn't hear from chromedriver in a while; let's " +
"assume it started OK");
cb();
}
}.bind(this), 500);