From 153ad5ea3e6fc2f70bc19d9682bf2e8536d31da0 Mon Sep 17 00:00:00 2001
From: Arian Daneshvar <arian.daneshvar@gmail.com>
Date: Tue, 15 Apr 2025 15:05:41 -0700
Subject: [PATCH] add lint fixes

---
 .../src/components/community/GeneralComments.vue |  2 +-
 .../edition_group/CreateOrEditEditionGroup.vue   |  4 ++--
 .../components/request/TorrentRequestsTable.vue  |  2 +-
 .../title_group/CreateOrEditTitleGroup.vue       |  4 ++--
 .../title_group/CreateOrSelectTitleGroup.vue     |  4 ++--
 .../title_group/TitleGroupPreviewCoverOnly.vue   |  2 --
 .../components/title_group/TitleGroupTable.vue   | 16 +++++++++-------
 frontend/src/services/api/artistService.ts       |  2 +-
 frontend/src/services/api/authService.ts         |  4 ++--
 .../src/services/api/externalDatabasesService.ts |  2 +-
 frontend/src/services/api/generalService.ts      |  4 ++--
 frontend/src/services/api/seriesService.ts       |  2 +-
 frontend/src/services/api/torrentService.ts      |  6 +++---
 .../fileinfo/mediainfo/mediainfoParser.js        |  2 +-
 frontend/src/services/helpers.ts                 |  4 ++--
 frontend/src/views/ArtistView.vue                | 15 ++++++++-------
 frontend/src/views/SeriesView.vue                | 15 ++++++++-------
 frontend/src/views/TorrentSearchView.vue         | 15 ++++++++-------
 18 files changed, 54 insertions(+), 51 deletions(-)

diff --git a/frontend/src/components/community/GeneralComments.vue b/frontend/src/components/community/GeneralComments.vue
index f12e4552..9c83ea70 100644
--- a/frontend/src/components/community/GeneralComments.vue
+++ b/frontend/src/components/community/GeneralComments.vue
@@ -80,7 +80,7 @@ export default {
         this.new_comment.answers_to_comment_id = null
         data.created_by = {}
         data.created_by = useUserStore()
-        // TODO: don't mutate the prop
+        // eslint-disable-next-line vue/no-mutating-props -- TODO: don't mutate the prop
         this.comments.push(data)
         this.sending_comment = false
       })
diff --git a/frontend/src/components/edition_group/CreateOrEditEditionGroup.vue b/frontend/src/components/edition_group/CreateOrEditEditionGroup.vue
index f3333d3c..f5d6db35 100644
--- a/frontend/src/components/edition_group/CreateOrEditEditionGroup.vue
+++ b/frontend/src/components/edition_group/CreateOrEditEditionGroup.vue
@@ -235,13 +235,13 @@ export default {
     addCover() {
       this.editionGroupForm.covers.push('')
     },
-    removeCover(index: Number) {
+    removeCover(index: number) {
       this.editionGroupForm.covers.splice(index, 1)
     },
     addLink() {
       this.editionGroupForm.external_links.push('')
     },
-    removeLink(index: Number) {
+    removeLink(index: number) {
       this.editionGroupForm.external_links.splice(index, 1)
     },
   },
diff --git a/frontend/src/components/request/TorrentRequestsTable.vue b/frontend/src/components/request/TorrentRequestsTable.vue
index d997bfce..15171b48 100644
--- a/frontend/src/components/request/TorrentRequestsTable.vue
+++ b/frontend/src/components/request/TorrentRequestsTable.vue
@@ -28,7 +28,7 @@ export default {
     torrent_requests: {},
   },
   methods: {
-    bytesToReadable(bytes: Number) {
+    bytesToReadable(bytes: number) {
       return bytesToReadable(bytes)
     },
   },
diff --git a/frontend/src/components/title_group/CreateOrEditTitleGroup.vue b/frontend/src/components/title_group/CreateOrEditTitleGroup.vue
index b0cbfc2e..7131f85a 100644
--- a/frontend/src/components/title_group/CreateOrEditTitleGroup.vue
+++ b/frontend/src/components/title_group/CreateOrEditTitleGroup.vue
@@ -286,13 +286,13 @@ export default {
     addLink() {
       this.titleGroupForm.external_links.push('')
     },
-    removeLink(index: Number) {
+    removeLink(index: number) {
       this.titleGroupForm.external_links.splice(index, 1)
     },
     addCover() {
       this.titleGroupForm.covers.push('')
     },
-    removeCover(index: Number) {
+    removeCover(index: number) {
       this.titleGroupForm.covers.splice(index, 1)
     },
   },
diff --git a/frontend/src/components/title_group/CreateOrSelectTitleGroup.vue b/frontend/src/components/title_group/CreateOrSelectTitleGroup.vue
index 8fee6fcf..bead9148 100644
--- a/frontend/src/components/title_group/CreateOrSelectTitleGroup.vue
+++ b/frontend/src/components/title_group/CreateOrSelectTitleGroup.vue
@@ -191,7 +191,7 @@ export default {
     return { titleGroupStore }
   },
   methods: {
-    getExternalDatabaseData(item_id: string | Number, database: string) {
+    getExternalDatabaseData(item_id: string | number, database: string) {
       this.gettingExternalDatabaseData = true
       getExternalDatabaseData(item_id, database).then((data) => {
         data.title_group.original_release_date = new Date(data.title_group.original_release_date)
@@ -204,7 +204,7 @@ export default {
         this.gettingExternalDatabaseData = false
       })
     },
-    async sendTitleGroup(titleGroupForm: Object) {
+    async sendTitleGroup(titleGroupForm: object) {
       if (this.action == 'select') {
         this.gettingTitleGroupInfo = true
         if (!this.titleGroupStore.id) {
diff --git a/frontend/src/components/title_group/TitleGroupPreviewCoverOnly.vue b/frontend/src/components/title_group/TitleGroupPreviewCoverOnly.vue
index 5849da69..22ad3504 100644
--- a/frontend/src/components/title_group/TitleGroupPreviewCoverOnly.vue
+++ b/frontend/src/components/title_group/TitleGroupPreviewCoverOnly.vue
@@ -11,9 +11,7 @@
   </div>
 </template>
 <script lang="ts">
-import { Image } from 'primevue'
 export default {
-  components: { Image },
   props: {
     title_group: {},
   },
diff --git a/frontend/src/components/title_group/TitleGroupTable.vue b/frontend/src/components/title_group/TitleGroupTable.vue
index 20f844ad..604147cd 100644
--- a/frontend/src/components/title_group/TitleGroupTable.vue
+++ b/frontend/src/components/title_group/TitleGroupTable.vue
@@ -179,9 +179,11 @@ export default {
       const reportedTorrent = this.title_group.edition_groups
         .flatMap((edition_group) => edition_group.torrents)
         .find((torrent) => torrent.id == torrentReport.reported_torrent_id)
-      reportedTorrent.reports
-        ? reportedTorrent.reports.push(torrentReport)
-        : (reportedTorrent.reports = [torrentReport])
+      if (reportedTorrent.reports) {
+        reportedTorrent.reports.push(torrentReport)
+      } else {
+        reportedTorrent.reports = [torrentReport]
+      }
     },
     reportTorrent(id: number) {
       this.reportingTorrentId = id
@@ -197,13 +199,13 @@ export default {
     timeAgo(date: string) {
       return timeAgo(date)
     },
-    bytesToReadable(bytes: Number) {
+    bytesToReadable(bytes: number) {
       return bytesToReadable(bytes)
     },
     purifyHtml(html: string) {
       return DOMPurify.sanitize(html)
     },
-    downloadTorrent(torrentId: Number) {
+    downloadTorrent(torrentId: number) {
       downloadTorrent(torrentId)
     },
   },
@@ -218,9 +220,9 @@ export default {
   },
   computed: {
     getEditionGroupSlug() {
-      return (id: Number) => {
+      return (id: number) => {
         return getEditionGroupSlug(
-          this.title_group.edition_groups.find((group: Object) => group.id === id),
+          this.title_group.edition_groups.find((group: object) => group.id === id),
         )
       }
     },
diff --git a/frontend/src/services/api/artistService.ts b/frontend/src/services/api/artistService.ts
index 0fc8a16d..69bc348a 100644
--- a/frontend/src/services/api/artistService.ts
+++ b/frontend/src/services/api/artistService.ts
@@ -1,6 +1,6 @@
 import api from './api.ts'
 
-export const getArtist = async (id: string | Number) => {
+export const getArtist = async (id: string | number) => {
   try {
     return (await api.get('/artist?id=' + id)).data
   } catch (error) {
diff --git a/frontend/src/services/api/authService.ts b/frontend/src/services/api/authService.ts
index 769fbac4..5e5e8e9c 100644
--- a/frontend/src/services/api/authService.ts
+++ b/frontend/src/services/api/authService.ts
@@ -1,6 +1,6 @@
 import api from './api.ts'
 
-export const login = async (form: Object) => {
+export const login = async (form: object) => {
   try {
     return (await api.post('/login', form)).data
   } catch (error) {
@@ -9,7 +9,7 @@ export const login = async (form: Object) => {
   }
 }
 
-export const register = async (form: Object) => {
+export const register = async (form: object) => {
   try {
     return (await api.post('/register', form)).data
   } catch (error) {
diff --git a/frontend/src/services/api/externalDatabasesService.ts b/frontend/src/services/api/externalDatabasesService.ts
index 34ebeea6..e8577a84 100644
--- a/frontend/src/services/api/externalDatabasesService.ts
+++ b/frontend/src/services/api/externalDatabasesService.ts
@@ -1,6 +1,6 @@
 import api from './api.ts'
 
-export const getExternalDatabaseData = async (item_id: string | Number, database: string) => {
+export const getExternalDatabaseData = async (item_id: string | number, database: string) => {
   try {
     switch (database) {
       case 'openlibrary': {
diff --git a/frontend/src/services/api/generalService.ts b/frontend/src/services/api/generalService.ts
index ade94928..513b4351 100644
--- a/frontend/src/services/api/generalService.ts
+++ b/frontend/src/services/api/generalService.ts
@@ -1,6 +1,6 @@
 import api from './api.ts'
 
-export const subscribeToItem = async (item_id: string | Number, item: string) => {
+export const subscribeToItem = async (item_id: string | number, item: string) => {
   try {
     return (await api.post('/subscription?item=' + item + '&item_id=' + item_id)).data
   } catch (error) {
@@ -8,7 +8,7 @@ export const subscribeToItem = async (item_id: string | Number, item: string) =>
     throw error
   }
 }
-export const unsubscribeToItem = async (item_id: string | Number, item: string) => {
+export const unsubscribeToItem = async (item_id: string | number, item: string) => {
   try {
     return (await api.delete('/subscription?item=' + item + '&item_id=' + item_id)).data
   } catch (error) {
diff --git a/frontend/src/services/api/seriesService.ts b/frontend/src/services/api/seriesService.ts
index 0bae8918..62d98480 100644
--- a/frontend/src/services/api/seriesService.ts
+++ b/frontend/src/services/api/seriesService.ts
@@ -1,6 +1,6 @@
 import api from './api.ts'
 
-export const getSeries = async (id: string | Number) => {
+export const getSeries = async (id: string | number) => {
   try {
     return (await api.get('/series?id=' + id)).data
   } catch (error) {
diff --git a/frontend/src/services/api/torrentService.ts b/frontend/src/services/api/torrentService.ts
index ae68ff04..0a0e018e 100644
--- a/frontend/src/services/api/torrentService.ts
+++ b/frontend/src/services/api/torrentService.ts
@@ -1,6 +1,6 @@
 import api from './api.ts'
 
-export const getTitleGroup = async (id: string | Number) => {
+export const getTitleGroup = async (id: string | number) => {
   try {
     return (await api.get('/title-group?id=' + id)).data
   } catch (error) {
@@ -8,7 +8,7 @@ export const getTitleGroup = async (id: string | Number) => {
     throw error
   }
 }
-export const getTitleGroupLite = async (id: string | Number) => {
+export const getTitleGroupLite = async (id: string | number) => {
   try {
     return (await api.get('/title-group/lite?id=' + id)).data
   } catch (error) {
@@ -52,7 +52,7 @@ export const uploadTorrent = async (torrentForm: object) => {
     throw error
   }
 }
-export const downloadTorrent = async (torrentId: Number | string) => {
+export const downloadTorrent = async (torrentId: number | string) => {
   try {
     const response = await api.get('/torrent?id=' + torrentId, {
       responseType: 'blob',
diff --git a/frontend/src/services/fileinfo/mediainfo/mediainfoParser.js b/frontend/src/services/fileinfo/mediainfo/mediainfoParser.js
index 2c2881c2..ca241753 100644
--- a/frontend/src/services/fileinfo/mediainfo/mediainfoParser.js
+++ b/frontend/src/services/fileinfo/mediainfo/mediainfoParser.js
@@ -35,7 +35,7 @@ export default class MediainfoParser {
     return result
   }
 
-  extractFields({ sectionName, sectionBody }) {
+  extractFields({ sectionName: _sectionName, sectionBody }) {
     const result = {}
     const lines = splitIntoLines(sectionBody)
     for (const line of lines) {
diff --git a/frontend/src/services/helpers.ts b/frontend/src/services/helpers.ts
index 44012689..d946b087 100644
--- a/frontend/src/services/helpers.ts
+++ b/frontend/src/services/helpers.ts
@@ -8,7 +8,7 @@ export const timeAgo = (date: string) => {
         ? `${Math.floor(diff / 3600)}h ago`
         : `${Math.floor(diff / 86400)}d ago`
 }
-export const bytesToReadable = (bytes: Number) => {
+export const bytesToReadable = (bytes: number) => {
   const units = ['B', 'KiB', 'MiB', 'GiB', 'TiB']
   let size = bytes
   let unitIndex = 0
@@ -69,7 +69,7 @@ export const isValidUrl = (url: string) => {
   try {
     new URL(url)
     return true
-  } catch (_) {
+  } catch {
     return false
   }
 }
diff --git a/frontend/src/views/ArtistView.vue b/frontend/src/views/ArtistView.vue
index f31afaf4..cb8caabd 100644
--- a/frontend/src/views/ArtistView.vue
+++ b/frontend/src/views/ArtistView.vue
@@ -22,13 +22,14 @@
           />
         </div>
       </ContentContainer>
-      <TitleGroupPreviewTable
-        v-for="title_group in title_groups"
-        :key="title_group.id"
-        :title_group="title_group"
-        v-if="title_group_preview_mode == 'table'"
-        class="preview-table"
-      />
+      <div v-if="title_group_preview_mode == 'table'">
+        <TitleGroupPreviewTable
+          v-for="title_group in title_groups"
+          :key="title_group.id"
+          :title_group="title_group"
+          class="preview-table"
+        />
+      </div>
     </div>
     <ArtistSidebar :artist />
   </div>
diff --git a/frontend/src/views/SeriesView.vue b/frontend/src/views/SeriesView.vue
index 4d3e920f..8c2a6b45 100644
--- a/frontend/src/views/SeriesView.vue
+++ b/frontend/src/views/SeriesView.vue
@@ -22,13 +22,14 @@
           />
         </div>
       </ContentContainer>
-      <TitleGroupPreviewTable
-        v-for="title_group in title_groups"
-        :key="title_group.id"
-        :title_group="title_group"
-        v-if="title_group_preview_mode == 'table'"
-        class="preview-table"
-      />
+      <div v-if="title_group_preview_mode == 'table'">
+        <TitleGroupPreviewTable
+          v-for="title_group in title_groups"
+          :key="title_group.id"
+          :title_group="title_group"
+          class="preview-table"
+        />
+      </div>
     </div>
     <SeriesSidebar :series />
   </div>
diff --git a/frontend/src/views/TorrentSearchView.vue b/frontend/src/views/TorrentSearchView.vue
index 432e9e6f..1faca3c3 100644
--- a/frontend/src/views/TorrentSearchView.vue
+++ b/frontend/src/views/TorrentSearchView.vue
@@ -15,13 +15,14 @@
         />
       </div>
     </ContentContainer>
-    <TitleGroupPreviewTable
-      v-for="title_group in search_results.title_groups"
-      :key="title_group.id"
-      :title_group="title_group"
-      v-if="title_group_preview_mode == 'table'"
-      class="preview-table"
-    />
+    <div v-if="title_group_preview_mode == 'table'">
+      <TitleGroupPreviewTable
+        v-for="title_group in search_results.title_groups"
+        :key="title_group.id"
+        :title_group="title_group"
+        class="preview-table"
+      />
+    </div>
   </div>
 </template>