mirror/bugsink
1
0
Fork 0
mirror of https://github.com/bugsink/bugsink.git synced 2026-05-06 23:10:00 -05:00
Code Issues Packages Projects Releases Wiki Activity

Clarify the meaning of Django's savepoint argument

Browse Source
This commit is contained in:
Klaas van Schelven
2024-04-26 20:51:19 +02:00
parent 653f4381c1
commit b261c21a61
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
bugsink/transaction.py
+6 -2
View File
@@ -105,8 +105,12 @@ class ImmediateAtomic(django_db_transaction.Atomic):
def immediate_atomic(using=None, savepoint=True, durable=True):
# this is the Django 4.2 db.transaction.atomic, but using ImmediateAtomic, and with durable=True by default
# the following assertion is because "BEGIN IMMEDIATE" supposes a "BEGIN" (of a transaction), i.e. has no meaning in
# the context of savepoints.
# the following assertion is because "BEGIN IMMEDIATE" supposes a "BEGIN" (of a transaction), i.e. has no meaning
# when this wrapper is not the outermost one.
# Side-note: the parameter `savepoint` is a bit of a misnomer, it is not about "is the current thing a savepoint",
# but rather, "are savepoints allowed inside the current context". (The former would imply that it could never be
# combined with durable=True, which is not the case.)
assert durable, "immediate_atomic should always be used with durable=True"
if callable(using):