From cc861c8ba3d39c2be6aa5f08ed80ca1af57a9c28 Mon Sep 17 00:00:00 2001 From: Klaas van Schelven Date: Sun, 9 Feb 2025 21:12:25 +0100 Subject: [PATCH] Remove 2 fields that were "temporary [..] to get a sense of the shape of the data --- events/admin.py | 6 ------ events/factories.py | 2 -- ...has_exception_remove_event_has_logentry.py | 21 +++++++++++++++++++ events/models.py | 5 ----- 4 files changed, 21 insertions(+), 13 deletions(-) create mode 100644 events/migrations/0018_remove_event_has_exception_remove_event_has_logentry.py diff --git a/events/admin.py b/events/admin.py index eac97a7..d9a4fb4 100644 --- a/events/admin.py +++ b/events/admin.py @@ -35,8 +35,6 @@ class EventAdmin(admin.ModelAdmin): 'level', 'sdk_name', 'sdk_version', - 'has_exception', - 'has_logentry', 'debug_info', 'on_site', ] @@ -47,8 +45,6 @@ class EventAdmin(admin.ModelAdmin): 'level', 'sdk_name', 'sdk_version', - 'has_exception', - 'has_logentry', ] fields = [ @@ -71,8 +67,6 @@ class EventAdmin(admin.ModelAdmin): 'environment', 'sdk_name', 'sdk_version', - 'has_exception', - 'has_logentry', 'debug_info', 'pretty_data', ] diff --git a/events/factories.py b/events/factories.py index 1115be3..bd3a9ef 100644 --- a/events/factories.py +++ b/events/factories.py @@ -37,8 +37,6 @@ def create_event(project=None, issue=None, timestamp=None, event_data=None): digested_at=timestamp, timestamp=timestamp, event_id=uuid.uuid4().hex, - has_exception=True, - has_logentry=True, data=json.dumps(event_data), digest_order=issue_digest_order, irrelevance_for_retention=0, diff --git a/events/migrations/0018_remove_event_has_exception_remove_event_has_logentry.py b/events/migrations/0018_remove_event_has_exception_remove_event_has_logentry.py new file mode 100644 index 0000000..5415f6d --- /dev/null +++ b/events/migrations/0018_remove_event_has_exception_remove_event_has_logentry.py @@ -0,0 +1,21 @@ +# Generated by Django 4.2.19 on 2025-02-09 20:11 + +from django.db import migrations + + +class Migration(migrations.Migration): + + dependencies = [ + ("events", "0017_alter_event_calculated_type_and_more"), + ] + + operations = [ + migrations.RemoveField( + model_name="event", + name="has_exception", + ), + migrations.RemoveField( + model_name="event", + name="has_logentry", + ), + ] diff --git a/events/models.py b/events/models.py index ceea688..82e718b 100644 --- a/events/models.py +++ b/events/models.py @@ -119,10 +119,6 @@ class Event(models.Model): sdk_name = models.CharField(max_length=255, blank=True, null=False, default="") sdk_version = models.CharField(max_length=255, blank=True, null=False, default="") - # these 2 are perhaps temporary, I made them up myself. Idea: ability to get a sense of the shape of the data quicly - has_exception = models.BooleanField(null=False) - has_logentry = models.BooleanField(null=False) - # this is a temporary(?), bugsink-specific value; debug_info = models.CharField(max_length=255, blank=True, null=False, default="") @@ -230,7 +226,6 @@ class Event(models.Model): sdk_name=maybe_empty(parsed_data.get("", {}).get("name", ""))[:255], sdk_version=maybe_empty(parsed_data.get("", {}).get("version", ""))[:255], - has_exception="exception" in parsed_data, has_logentry="logentry" in parsed_data, debug_info=event_metadata["debug_info"][:255],