From eb08bd562c47ed6da545669eea8758b3be4b60ed Mon Sep 17 00:00:00 2001 From: Klaas van Schelven Date: Thu, 12 Sep 2024 13:58:36 +0200 Subject: [PATCH] When there's no (meaningful) release info, don't display it --- issues/models.py | 4 ++++ issues/templates/issues/base.html | 4 ++-- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/issues/models.py b/issues/models.py index f809412..cfee863 100644 --- a/issues/models.py +++ b/issues/models.py @@ -83,6 +83,10 @@ class Issue(models.Model): def get_events_at(self): return parse_lines(self.events_at) + def get_events_at_2(self): + # _2: a great Python tradition; in this case: the same as get_events_at(), but ignoring the 'no release' release + return [e for e in self.get_events_at() if e != ""] + def add_fixed_at(self, release_version): # release_version: str fixed_at = self.get_fixed_at() diff --git a/issues/templates/issues/base.html b/issues/templates/issues/base.html index 4496847..d88e795 100644 --- a/issues/templates/issues/base.html +++ b/issues/templates/issues/base.html @@ -190,11 +190,11 @@ {% endif %} - {% if issue.get_events_at %} + {% if issue.get_events_at_2 %}
Seen in releases:
- {% for version in issue.get_events_at %} + {% for version in issue.get_events_at_2 %} {{ version|shortsha }}{% if not forloop.last %},{% endif %} {% endfor %}