From 0cddaee67f834bb645585afd09ed80f5788ca3cf Mon Sep 17 00:00:00 2001 From: Guy Ben-Aharon Date: Mon, 7 Oct 2024 17:13:10 +0300 Subject: [PATCH] update dependencies order (#255) --- .../dependencies-section.tsx | 13 ++++++- .../dependency-list-item-content.tsx | 36 +++++++++---------- .../dependency-list-item-header.tsx | 2 +- 3 files changed, 31 insertions(+), 20 deletions(-) diff --git a/src/pages/editor-page/side-panel/dependencies-section/dependencies-section.tsx b/src/pages/editor-page/side-panel/dependencies-section/dependencies-section.tsx index 92c47c28..1ca6f4d7 100644 --- a/src/pages/editor-page/side-panel/dependencies-section/dependencies-section.tsx +++ b/src/pages/editor-page/side-panel/dependencies-section/dependencies-section.tsx @@ -48,7 +48,18 @@ export const DependenciesSection: React.FC = () => { dependency ) => shouldShowDependencyBySchemaFilter(dependency, filteredSchemas); - return dependencies.filter(filterSchema).filter(filterName); + return dependencies + .filter(filterSchema) + .filter(filterName) + .sort((a, b) => { + const dependentTableA = getTable(a.dependentTableId); + const tableA = getTable(a.tableId); + const dependentTableB = getTable(b.dependentTableId); + const tableB = getTable(b.tableId); + return `${dependentTableA?.name}${tableA?.name}`.localeCompare( + `${dependentTableB?.name}${tableB?.name}` + ); + }); }, [dependencies, filterText, filteredSchemas, getTable]); return ( diff --git a/src/pages/editor-page/side-panel/dependencies-section/dependency-list/dependency-list-item/dependency-list-item-content/dependency-list-item-content.tsx b/src/pages/editor-page/side-panel/dependencies-section/dependency-list/dependency-list-item/dependency-list-item-content/dependency-list-item-content.tsx index 5e329f22..ef8ee6c0 100644 --- a/src/pages/editor-page/side-panel/dependencies-section/dependency-list/dependency-list-item/dependency-list-item-content/dependency-list-item-content.tsx +++ b/src/pages/editor-page/side-panel/dependencies-section/dependency-list/dependency-list-item/dependency-list-item-content/dependency-list-item-content.tsx @@ -36,24 +36,6 @@ export const DependencyListItemContent: React.FC<
-
-
- -
- {t( - 'side_panel.dependencies_section.dependency.table' - )} -
-
- - -
- {table?.name} -
-
- {table?.name} -
-
@@ -74,6 +56,24 @@ export const DependencyListItemContent: React.FC<
+
+
+ +
+ {t( + 'side_panel.dependencies_section.dependency.table' + )} +
+
+ + +
+ {table?.name} +
+
+ {table?.name} +
+
diff --git a/src/pages/editor-page/side-panel/dependencies-section/dependency-list/dependency-list-item/dependency-list-item-header/dependency-list-item-header.tsx b/src/pages/editor-page/side-panel/dependencies-section/dependency-list/dependency-list-item/dependency-list-item-header/dependency-list-item-header.tsx index 81076a71..bebb7134 100644 --- a/src/pages/editor-page/side-panel/dependencies-section/dependency-list/dependency-list-item/dependency-list-item-header/dependency-list-item-header.tsx +++ b/src/pages/editor-page/side-panel/dependencies-section/dependency-list/dependency-list-item/dependency-list-item-header/dependency-list-item-header.tsx @@ -39,7 +39,7 @@ export const DependencyListItemHeader: React.FC< return ''; } - return `${table.name} -> ${dependentTable.name}`; + return `${dependentTable.name} -> ${table.name}`; }, [dependency.tableId, dependency.dependentTableId, getTable]); const focusOnDependency = useCallback(