From 0c777e0582e5e644b4d2ddcf6275460e70593344 Mon Sep 17 00:00:00 2001 From: Morgan Dean Date: Wed, 2 Jul 2025 11:18:32 -0700 Subject: [PATCH 1/2] Fix action issues with typescript libs, warnings on core lib --- .github/workflows/npm-publish-computer.yml | 7 ++++--- .github/workflows/npm-publish-core.yml | 7 ++++--- libs/typescript/core/tsdown.config.ts | 2 +- 3 files changed, 9 insertions(+), 7 deletions(-) diff --git a/.github/workflows/npm-publish-computer.yml b/.github/workflows/npm-publish-computer.yml index 328378d7..e2949f4c 100644 --- a/.github/workflows/npm-publish-computer.yml +++ b/.github/workflows/npm-publish-computer.yml @@ -22,14 +22,15 @@ jobs: - name: Install dependencies working-directory: ./libs/typescript/computer - run: npm ci + run: pnpm install --frozen-lockfile - name: Build package working-directory: ./libs/typescript/computer - run: npm run build --if-present + run: pnpm run build --if-present - name: Publish to npm working-directory: ./libs/typescript/computer - run: npm publish --provenance --access public + run: pnpm publish --access public --no-git-checks env: + NPM_CONFIG_PROVENANCE: true NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }} diff --git a/.github/workflows/npm-publish-core.yml b/.github/workflows/npm-publish-core.yml index dc06628d..3f02f8f2 100644 --- a/.github/workflows/npm-publish-core.yml +++ b/.github/workflows/npm-publish-core.yml @@ -22,14 +22,15 @@ jobs: - name: Install dependencies working-directory: ./libs/typescript/core - run: npm ci + run: pnpm install --frozen-lockfile - name: Build package working-directory: ./libs/typescript/core - run: npm run build --if-present + run: pnpm run build --if-present - name: Publish to npm working-directory: ./libs/typescript/core - run: npm publish --provenance --access public + run: pnpm publish --access public --no-git-checks env: + NPM_CONFIG_PROVENANCE: true NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }} diff --git a/libs/typescript/core/tsdown.config.ts b/libs/typescript/core/tsdown.config.ts index 21d62816..36743757 100644 --- a/libs/typescript/core/tsdown.config.ts +++ b/libs/typescript/core/tsdown.config.ts @@ -3,7 +3,7 @@ import { defineConfig } from 'tsdown'; export default defineConfig([ { entry: ['./src/index.ts'], - platform: 'neutral', + platform: 'node', dts: true, }, ]); From b84f037134ea130a1061507a6f834000018af252 Mon Sep 17 00:00:00 2001 From: Morgan Dean Date: Wed, 2 Jul 2025 12:20:13 -0700 Subject: [PATCH 2/2] Update npm packages to publish if version changes --- .github/workflows/npm-publish-computer.yml | 14 ++++++++++++-- .github/workflows/npm-publish-core.yml | 14 ++++++++++++-- 2 files changed, 24 insertions(+), 4 deletions(-) diff --git a/.github/workflows/npm-publish-computer.yml b/.github/workflows/npm-publish-computer.yml index e2949f4c..f8240d64 100644 --- a/.github/workflows/npm-publish-computer.yml +++ b/.github/workflows/npm-publish-computer.yml @@ -2,8 +2,7 @@ name: Publish @trycua/computer to npm on: push: - tags: - - "computer-v*" + branches: main jobs: publish: @@ -20,15 +19,26 @@ jobs: node-version: "24.x" registry-url: "https://registry.npmjs.org" + - name: Check if version changed + id: check-version + uses: EndBug/version-check@v2 + with: + file-name: libs/typescript/computer/package.json + static-checking: localIsNew + diff-search: true + - name: Install dependencies + if: steps.check-version.outputs.changed == 'true' working-directory: ./libs/typescript/computer run: pnpm install --frozen-lockfile - name: Build package + if: steps.check-version.outputs.changed == 'true' working-directory: ./libs/typescript/computer run: pnpm run build --if-present - name: Publish to npm + if: steps.check-version.outputs.changed == 'true' working-directory: ./libs/typescript/computer run: pnpm publish --access public --no-git-checks env: diff --git a/.github/workflows/npm-publish-core.yml b/.github/workflows/npm-publish-core.yml index 3f02f8f2..7d75e6c6 100644 --- a/.github/workflows/npm-publish-core.yml +++ b/.github/workflows/npm-publish-core.yml @@ -2,8 +2,7 @@ name: Publish @trycua/core to npm on: push: - tags: - - "core-v*" + branches: main jobs: publish: @@ -20,15 +19,26 @@ jobs: node-version: "24.x" registry-url: "https://registry.npmjs.org" + - name: Check if version changed + id: check-version + uses: EndBug/version-check@v2 + with: + file-name: libs/typescript/core/package.json + static-checking: localIsNew + diff-search: true + - name: Install dependencies + if: steps.check-version.outputs.changed == 'true' working-directory: ./libs/typescript/core run: pnpm install --frozen-lockfile - name: Build package + if: steps.check-version.outputs.changed == 'true' working-directory: ./libs/typescript/core run: pnpm run build --if-present - name: Publish to npm + if: steps.check-version.outputs.changed == 'true' working-directory: ./libs/typescript/core run: pnpm publish --access public --no-git-checks env: