mirror/cypress
1
0
Fork 0
mirror of https://github.com/cypress-io/cypress.git synced 2026-03-03 05:19:45 -06:00
Code Issues Packages Projects Releases Wiki Activity

fix: get correct env from npm config (#24664)

Browse Source 
* fix: get correct env from npm config

`npm config set VAR VAL` will inject `npm_config_var=val` environment
variable. This commit will solve this issue

Closes: #24556

* Disable commercial recommendations for system tests.

* Disable commercial recommendations

* Update system-tests/lib/system-tests.ts

* Revert changes

* Update cli/test/lib/util_spec.js

* Update cli/test/lib/util_spec.js

Co-authored-by: Matt Henkes <mjhenkes@gmail.com>
This commit is contained in:
Feng Yu
2022-12-02 05:43:24 +08:00
committed by GitHub
parent c2c21c29d4
commit 05dc4a5ecd
2 changed files with 10 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
cli/lib/util.js
View File

@@ -533,6 +533,7 @@ const util = {
la(is.unemptyString(varName), 'expected environment variable name, not', varName)
const configVarName = `npm_config_${varName}`
const configVarNameLower = configVarName.toLowerCase()
const packageConfigVarName = `npm_package_config_${varName}`
let result
@@ -545,6 +546,10 @@ const util = {
debug(`Using ${varName} from npm config`)
result = process.env[configVarName]
} else if (process.env.hasOwnProperty(configVarNameLower)) {
debug(`Using ${varName.toLowerCase()} from npm config`)
result = process.env[configVarNameLower]
} else if (process.env.hasOwnProperty(packageConfigVarName)) {
debug(`Using ${varName} from package.json config`)

5
cli/test/lib/util_spec.js
View File

@@ -543,6 +543,11 @@ describe('util', () => {
expect(util.getEnv('CYPRESS_FOO')).to.eql('')
})
it('npm config set should work', () => {
process.env.npm_config_cypress_foo_foo = 'bazz'
expect(util.getEnv('CYPRESS_FOO_FOO')).to.eql('bazz')
})
it('throws on non-string name', () => {
expect(() => {
util.getEnv()