mirror/cypress
1
0
Fork 0
mirror of https://github.com/cypress-io/cypress.git synced 2026-05-02 04:50:06 -05:00
Code Issues Packages Projects Releases Wiki Activity

server: accept only allowed content encodings (gzip)

Browse Source
This commit is contained in:
Brian Mann
2017-06-14 18:09:26 -04:00
parent a2833adb83
commit 2421180cae
2 changed files with 53 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/server/lib/controllers/proxy.coffee
+11
View File
@@ -234,6 +234,17 @@ module.exports = {
# opts = {url: remoteUrl, followRedirect: false, strictSSL: false}
opts = {followRedirect: false, strictSSL: false}
## strip unsupported accept-encoding headers
encodings = accept.parser(req.headers["accept-encoding"]) ? []
if "gzip" in encodings
## we only want to support gzip right now
req.headers["accept-encoding"] = "gzip"
else
## else just delete them since we cannot
## properly decode them
delete req.headers["accept-encoding"]
if remoteState.strategy is "file" and req.proxiedUrl.startsWith(remoteState.origin)
opts.url = req.proxiedUrl.replace(remoteState.origin, remoteState.fileServer)
else
packages/server/test/integration/http_requests_spec.coffee
+42 -3
View File
@@ -925,7 +925,7 @@ describe "Routes", ->
it "unzips, injects, and then rezips initial content", ->
nock(@server._remoteOrigin)
.get("/gzip")
.matchHeader("accept-encoding", /gzip/)
.matchHeader("accept-encoding", "gzip")
.replyWithFile(200, Fixtures.path("server/gzip.html.gz"), {
"Content-Type": "text/html"
"Content-Encoding": "gzip"
@@ -949,7 +949,7 @@ describe "Routes", ->
it "unzips, injects, and then rezips regular http content", ->
nock(@server._remoteOrigin)
.get("/gzip")
.matchHeader("accept-encoding", /gzip/)
.matchHeader("accept-encoding", "gzip")
.replyWithFile(200, Fixtures.path("server/gzip.html.gz"), {
"Content-Type": "text/html"
"Content-Encoding": "gzip"
@@ -973,7 +973,7 @@ describe "Routes", ->
it "does not inject on regular gzip'd content", ->
nock(@server._remoteOrigin)
.get("/gzip")
.matchHeader("accept-encoding", /gzip/)
.matchHeader("accept-encoding", "gzip")
.replyWithFile(200, Fixtures.path("server/gzip.html.gz"), {
"Content-Type": "application/javascript"
"Content-Encoding": "gzip"
@@ -990,6 +990,45 @@ describe "Routes", ->
expect(res.body).not.to.include("document.domain = 'github.com'")
expect(res.body).to.include("</html>")
context "accept-encoding", ->
beforeEach ->
@setup("http://www.github.com")
it "strips unsupported deflate and br encoding", ->
nock(@server._remoteOrigin)
.get("/accept")
.matchHeader("accept-encoding", "gzip")
.reply(200, "<html>accept</html>")
@rp({
url: "http://www.github.com/accept"
gzip: true
headers: {
"accept-encoding": "gzip,deflate,br"
}
})
.then (res) ->
expect(res.statusCode).to.eq(200)
expect(res.body).to.eq("<html>accept</html>")
it "removes accept-encoding when nothing is supported", ->
nock(@server._remoteOrigin, {
badheaders: ["accept-encoding"]
})
.get("/accept")
.reply(200, "<html>accept</html>")
@rp({
url: "http://www.github.com/accept"
gzip: true
headers: {
"accept-encoding": "foo,bar,baz"
}
})
.then (res) ->
expect(res.statusCode).to.eq(200)
expect(res.body).to.eq("<html>accept</html>")
context "304 Not Modified", ->
beforeEach ->
@setup("http://localhost:8080")