mirror/cypress
1
0
Fork 0
mirror of https://github.com/cypress-io/cypress.git synced 2026-05-21 23:59:33 -05:00
Code Issues Packages Projects Releases Wiki Activity

refactor: remove __fakeInstalledPackagesForTesting (#20529)

Browse Source 
* refactor: remove __fakeInstalledPackagesForTesting, use sinon.stub

* make tests pass (avoid double mocking)

Co-authored-by: ElevateBart <ledouxb@gmail.com>
Co-authored-by: Barthélémy Ledoux <bart@cypress.io>
This commit is contained in:
Tim Griesser
2022-03-08 15:18:38 -05:00
committed by GitHub
parent 93f83d8613
commit 284ae6df6f
4 changed files with 4 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/data-context/src/data/coreDataShape.ts
-2
View File
@@ -70,7 +70,6 @@ export interface WizardDataShape {
detectedLanguage: NexusGenEnums['CodeLanguageEnum'] | null
detectedBundler: Bundler | null
detectedFramework: typeof FRONTEND_FRAMEWORKS[number]['type'] | null
__fakeInstalledPackagesForTesting: string[] | null
}
export interface MigrationDataShape{
@@ -168,7 +167,6 @@ export function makeCoreData (modeOptions: Partial<AllModeOptions> = {}): CoreDa
chosenManualInstall: false,
detectedBundler: null,
detectedFramework: null,
__fakeInstalledPackagesForTesting: null,
detectedLanguage: null,
},
migration: {
packages/data-context/src/sources/WizardDataSource.ts
-4
View File
@@ -66,10 +66,6 @@ export class WizardDataSource {
}
async installedPackages (): Promise<string[]> {
if (this.ctx.coreData.wizard.__fakeInstalledPackagesForTesting) {
return this.ctx.coreData.wizard.__fakeInstalledPackagesForTesting
}
const packagesInitial = await this.packagesToInstall() || []
if (!this.ctx.currentProject) {
packages/launchpad/cypress/e2e/project-setup.cy.ts
+2 -8
View File
@@ -2,12 +2,10 @@ import { BUNDLERS, FRONTEND_FRAMEWORKS, AllPackagePackages } from '@packages/sca
import { CODE_LANGUAGES } from '@packages/types/src'
function fakeInstalledDeps () {
cy.withCtx(async (ctx) => {
cy.withCtx(async (ctx, o) => {
const deps = (await ctx.wizard.packagesToInstall() ?? []).map((x) => x.package)
ctx.update((coreData) => {
coreData.wizard.__fakeInstalledPackagesForTesting = deps
})
o.sinon.stub(ctx.wizard, 'installedPackages').resolves(deps)
})
}
@@ -615,10 +613,6 @@ describe('Launchpad: Setup Project', () => {
})
})
beforeEach(() => {
fakeInstalledDeps()
})
const hasStorybookPermutations = [false, true]
FRONTEND_FRAMEWORKS.forEach((framework) => {
packages/launchpad/cypress/e2e/scaffold-component-testing.cy.ts
+2 -4
View File
@@ -19,12 +19,10 @@ function verifyConfigFile (configFile: `cypress.config.${'js' | 'ts'}`) {
}
function fakeInstalledDeps () {
cy.withCtx(async (ctx) => {
cy.withCtx(async (ctx, o) => {
const deps = (await ctx.wizard.packagesToInstall() ?? []).map((x) => x.package)
ctx.update((coreData) => {
coreData.wizard.__fakeInstalledPackagesForTesting = deps
})
o.sinon.stub(ctx.wizard, 'installedPackages').resolves(deps)
})
}