Use 'platform-arch' naming scheme for downloads (#3998)

* use 'platform-arch' naming scheme for downloads

* do full builds for this branch

* Revert "do full builds for this branch"

This reverts commit 6d539513e7.

* update wrong comments

* chore: test upload getCDN functions

* linting js

* unit test refactored manifest

* linting

scripts/unit/binary/upload-npm-package-spec.js

@@ -0,0 +1,23 @@
+const snapshot = require('snap-shot-it')
+
+/* eslint-env mocha */
+describe('getCDN', () => {
+  context('npm package', () => {
+    const { getCDN } = require('../../binary/upload-npm-package')
+
+    it('returns CDN s3 path', () => {
+      const options = {
+        platform: 'darwin-x64',
+        filename: 'cypress.tgz',
+        version: '3.3.0',
+        // ci name + commit sha + build number
+        hash: 'ci-name-e154a40f3f76abd39a1d85c0ebc0ff9565015706-123',
+      }
+
+      snapshot({
+        input: options,
+        result: getCDN(options),
+      })
+    })
+  })
+})

scripts/unit/binary/upload-spec.js

@@ -0,0 +1,16 @@
+const snapshot = require('snap-shot-it')
+
+/* eslint-env mocha */
+describe('upload', () => {
+  const upload = require('../../binary/upload')
+
+  context('getRemoteManifest', () => {
+    it('returns object with download urls for each platform', () => {
+      const folder = 'desktop'
+      const version = '3.3.0'
+      const manifest = upload.getRemoteManifest(folder, version)
+
+      snapshot('test runner manifest', manifest)
+    })
+  })
+})

scripts/unit/binary/upload-unique-binary-spec.js

@@ -0,0 +1,23 @@
+const snapshot = require('snap-shot-it')
+
+/* eslint-env mocha */
+describe('getCDN', () => {
+  context('binary', () => {
+    const { getCDN } = require('../../binary/upload-unique-binary')
+
+    it('returns CDN s3 path', () => {
+      const options = {
+        platform: 'darwin-x64',
+        filename: 'cypress.zip',
+        version: '3.3.0',
+        // ci name + commit sha + build number
+        hash: 'ci-name-e154a40f3f76abd39a1d85c0ebc0ff9565015706-123',
+      }
+
+      snapshot({
+        input: options,
+        result: getCDN(options),
+      })
+    })
+  })
+})