chore: upgrade cli eslint to 9 (#32446)

* chore: replace dtslint with eslint-plugin-expect-type

* update guide

* add lint-staged

* rm stale script

* modify cli eslint and tsconfigs to support ts migration

* separate expect-type files

* modifications to tsconfigs to make eslint a little easier

* revert workflow.yml

* further revision

* put tslint config for dtslint back in

* ensure false negative case is tested

* correct tsconfigs

* align dtslint tsconfig with eslint 9 config

* consolidate / DRY tsconfigs

cli/scripts/build.ts

@@ -74,10 +74,9 @@ export default makeUserPackageFile
 if (require.main === module) {
   makeUserPackageFile(process.env.BRANCH)
   .catch((err: any) => {
-    /* eslint-disable no-console */
     console.error('Could not write user package file')
     console.error(err)
-    /* eslint-enable no-console */
+
     process.exit(-1)
   })
 }

cli/scripts/post-install.ts

@@ -1,7 +1,7 @@
 #!/usr/bin/env node
 
 // @ts-check
-/* eslint-disable no-console */
+
 import fs from 'fs-extra'
 import { includeTypes } from './utils'
 import shell from 'shelljs'

cli/scripts/start-build.ts

@@ -23,7 +23,7 @@ includeTypes.forEach((folder: string) => {
 })
 
 // build the project and copy the build files over to the build directory
-shell.exec('tsc -p tsconfig.json')
+shell.exec('tsc -p tsconfig.build.json')
 shell.exec('tsc -p tsconfig.esm.json')
 
 shell.mkdir('-p', 'build/dist')

cli/scripts/tsconfig.json

@@ -0,0 +1,22 @@
+{
+  "compilerOptions": {
+    "module": "commonjs",
+    "lib": [
+      "node",
+    ],
+    "exactOptionalPropertyTypes": true,
+    "noImplicitAny": true,
+    "noImplicitThis": true,
+    "strictNullChecks": true,
+    "strictFunctionTypes": true,
+    "noUnusedLocals": false,
+    "noUnusedParameters": false,
+    "types": [],
+    "noEmit": true,
+    "forceConsistentCasingInFileNames": true,
+    "esModuleInterop": true
+  },
+  "include": [
+      "**/*.ts"
+  ]
+}