From 6933ef61ff64efeffdfd660b7960700c4cbabbb6 Mon Sep 17 00:00:00 2001 From: Mark Noonan Date: Tue, 6 Dec 2022 15:29:58 -0500 Subject: [PATCH] fix: restore spec filter in client side store (#24987) * run ci - bring back specFilter in store * restore test for saved search Co-authored-by: Matt Henkes --- packages/app/cypress/e2e/specs_list_e2e.cy.ts | 3 +-- packages/app/src/composables/useSpecFilter.ts | 1 + packages/app/src/store/specs-store.ts | 4 ++++ 3 files changed, 6 insertions(+), 2 deletions(-) diff --git a/packages/app/cypress/e2e/specs_list_e2e.cy.ts b/packages/app/cypress/e2e/specs_list_e2e.cy.ts index 4801f5ebf1..ba8279d246 100644 --- a/packages/app/cypress/e2e/specs_list_e2e.cy.ts +++ b/packages/app/cypress/e2e/specs_list_e2e.cy.ts @@ -245,8 +245,7 @@ describe('App: Spec List (E2E)', () => { cy.findByText('No specs matched your search:').should('not.be.visible') }) - // TODO: FIGURE OUT WHY THIS IS NOW FAILING CONSTANTLY - it.skip('saves the filter when navigating to a spec and back', function () { + it('saves the filter when navigating to a spec and back', function () { const targetSpecFile = 'accounts_list.spec.js' clearSearchAndType(targetSpecFile) diff --git a/packages/app/src/composables/useSpecFilter.ts b/packages/app/src/composables/useSpecFilter.ts index 3ba8620835..af2acd4ea0 100644 --- a/packages/app/src/composables/useSpecFilter.ts +++ b/packages/app/src/composables/useSpecFilter.ts @@ -25,6 +25,7 @@ export function useSpecFilter (savedFilter?: string) { function setSpecFilter (specFilter: string) { if (specStore.specFilter !== specFilter) { + specStore.setSpecFilter(specFilter) saveSpecFilter.executeMutation({ value: JSON.stringify({ specFilter }) }) } } diff --git a/packages/app/src/store/specs-store.ts b/packages/app/src/store/specs-store.ts index 396ef3b068..359519edc8 100644 --- a/packages/app/src/store/specs-store.ts +++ b/packages/app/src/store/specs-store.ts @@ -12,6 +12,7 @@ export const useSpecStore = defineStore({ state (): SpecState { return { activeSpec: undefined, + specFilter: undefined, } }, @@ -19,5 +20,8 @@ export const useSpecStore = defineStore({ setActiveSpec (activeSpec: SpecFile | null) { this.activeSpec = activeSpec }, + setSpecFilter (filter: string) { + this.specFilter = filter + }, }, })