properly skip describe suites + tests and add TODO comments

This commit is contained in:
Brian Mann
2022-02-18 17:08:44 -05:00
parent 186631173f
commit 6f2bccebd5
5 changed files with 11 additions and 8 deletions
+2 -1
View File
@@ -44,7 +44,8 @@ describe('CLI Interface', () => {
})
})
xit('writes out package.json and exits', (done) => {
// TODO:(tgriesser) originally skipped this, not sure why
it.skip('writes out package.json and exits', (done) => {
return cp.exec('npm run dev -- --return-pkg', { env }, (err, stdout, stderr) => {
if (err) {
done(err)
+4 -4
View File
@@ -593,8 +593,8 @@ describe('lib/config', () => {
})
})
// TODO(lachlan): after mega PR
xcontext('specPattern', () => {
// TODO:(lachlan): after mega PR
context.skip('specPattern', () => {
it('passes if a string', function () {
this.setup({ e2e: { specPattern: '**/*.coffee' } })
@@ -1459,8 +1459,8 @@ describe('lib/config', () => {
expect(warning).to.be.calledWith('FIREFOX_GC_INTERVAL_REMOVED')
})
// todo(lachlan): after mega PR
xdescribe('.resolved', () => {
// TODO:(lachlan) after mega PR
describe.skip('.resolved', () => {
it('sets reporter and port to cli', () => {
const obj = {
projectRoot: '/foo/bar',
+2 -1
View File
@@ -60,7 +60,8 @@ describe('lib/gui/events', () => {
})
})
xcontext('.start', () => {
// TODO:(tgriesser) originally skipped this, not sure why
context.skip('.start', () => {
it('ipc attaches callback on request', () => {
sinon.stub(events, 'handleEvent')
+1 -1
View File
@@ -39,7 +39,7 @@ describe('lib/server', () => {
// TODO: Figure out correct configuration to run these tests and/or which ones we need to keep.
// The introducion of server-base/socket-base and the `ensureProp` function made unit testing
// the server difficult.
xdescribe('lib/server', () => {
describe.skip('lib/server', () => {
beforeEach(function () {
this.fileServer = {
close () {},
+2 -1
View File
@@ -35,7 +35,8 @@ describe('e2e system node', () => {
expect(stderr).to.contain('Plugin Electron version: undefined')
})
xit('uses bundled node when launching plugins file', async function () {
// TODO:(tgriesser) originally skipped this, not sure why
it.skip('uses bundled node when launching plugins file', async function () {
const { stderr } = await systemTests.exec(this, {
project: 'system-node',
config: {